Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InfoCard): enhance accessibility + set max width of 60ch #1977

Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix(InfoCard): enhance accessibility + set max width of 60ch #1977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...-design-system-portal/src/docs/uilib/about-the-lib/releases/eufemia/v10-info.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,10 @@ When you convert from `<Modal />` to `<Dialog />` – follow these steps:

1. In v10, InputMasked **allows leading zeros**. To prevent that behaviour, the property `allowLeadingZeroes` has changed to `disallowLeadingZeroes`.

### Removal of `data-testid` in components

- [InfoCard](/uilib/components/info-card).

### [Stopped supporting Internet Explorer (IE)](/uilib/usage/#supported-browsers-and-platforms)

Stopped supporting Internet Explorer (IE), as Microsoft formally ended support for IE in June, 2022.
Expand Down
166 changes: 0 additions & 166 deletions packages/dnb-design-system-portal/src/docs/uilib/components/info-card/Examples.js
View file
Open in desktop

This file was deleted.

128 changes: 128 additions & 0 deletions packages/dnb-design-system-portal/src/docs/uilib/components/info-card/Examples.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
/**
* UI lib Component Example
*
*/

import React from 'react'
import ComponentBox from 'dnb-design-system-portal/src/shared/tags/ComponentBox'
import { card_medium as Card } from '@dnb/eufemia/src/icons'
import InfoCard from '@dnb/eufemia/src/components/info-card/InfoCard'

export const InfoCardBasic = () => (
<ComponentBox data-visual-test="info-card-basic">
<InfoCard text="This is a description of some information or a tip that will inform the user of something that will help them." />
</ComponentBox>
)

export const InfoCardTitle = () => (
<ComponentBox data-visual-test="info-card-title">
<InfoCard
text="This is a description of some information or a tip that will inform the user of something that will help them."
title="Title of your info/tip"
/>
</ComponentBox>
)

export const InfoCardButtons = () => (
<ComponentBox data-visual-test="info-card-buttons">
<InfoCard
text="This is a description of some information or a tip that will inform the user of something that will help them."
title="Title of your info/tip"
closeButtonText="Close"
onClose={() => {
console.log('onClose')
}}
acceptButtonText="Accept"
onAccept={() => {
console.log('onAccept')
}}
/>
</ComponentBox>
)

export const InfoCardButtonsCentered = () => (
<ComponentBox data-visual-test="info-card-buttons-centered">
<InfoCard
centered
text="This is a description of some information or a tip that will inform the user of something that will help them."
title="Title of your info/tip"
closeButtonText="Close"
onClose={() => {
console.log('onClose')
}}
acceptButtonText="Accept"
onAccept={() => {
console.log('onAccept')
}}
/>
</ComponentBox>
)

export const InfoCardAcceptButton = () => (
<ComponentBox data-visual-test="info-card-accept-button">
<InfoCard
text="This is a description of some information or a tip that will inform the user of something that will help them."
title="Title of your info/tip"
acceptButtonText="Accept"
onAccept={() => {
console.log('onAccept')
}}
/>
</ComponentBox>
)

export const InfoCardCloseButton = () => (
<ComponentBox data-visual-test="info-card-close-button">
<InfoCard
text="This is a description of some information or a tip that will inform the user of something that will help them."
title="Title of your info/tip"
closeButtonText="Close"
onClose={() => {
console.log('onClose')
}}
/>
</ComponentBox>
)

export const InfoCardCustomIcon = () => (
<ComponentBox scope={{ Card }} data-visual-test="info-card-custom-icon">
<InfoCard
text="This is a description of some information or a tip that will inform the user of something that will help them."
title="Title of your info/tip"
icon={Card}
/>
</ComponentBox>
)

export const InfoCardCentered = () => (
<ComponentBox data-visual-test="info-card-centered">
<InfoCard
text="This is a description of some information or a tip that will inform the user of something that will help them."
title="Title of your info/tip"
centered={true}
/>
</ComponentBox>
)

export const InfoCardCustomImage = () => (
<ComponentBox data-visual-test="info-card-custom-image">
<InfoCard
text="This is a description of some information or a tip that will inform the user of something that will help them."
title="This is the InfoCard with a custom image"
src="/images/avatars/1501870.jpg"
alt="Profile picture"
/>
</ComponentBox>
)

export const InfoCardCustomImageCentered = () => (
<ComponentBox data-visual-test="info-card-custom-image-centered">
<InfoCard
text="This is a description of some information or a tip that will inform the user of something that will help them."
title="This is the InfoCard with a custom image"
centered={true}
src="/images/avatars/1501870.jpg"
alt="Profile picture"
/>
</ComponentBox>
)
4 changes: 1 addition & 3 deletions packages/dnb-design-system-portal/src/docs/uilib/components/info-card/demos.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,11 @@ InfoCardCustomImageCentered,

### InfoCard with Buttons

Two buttons

<InfoCardButtons />

<InfoCardButtonsCentered />

Each button can be used independently
Each button can be used independently.

<InfoCardAcceptButton />

Expand Down
Loading