chore(Table): Revert: "remove deprecated selectors" #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0899140:
|
tujoworker
force-pushed
the
revert-1902-chore/remove-deprecated-selectors-in-table-cell
branch
2 times, most recently
from
834feb6 to
190dcf7
Compare
This reverts commit 92bb52e.
tujoworker
force-pushed
the
revert-1902-chore/remove-deprecated-selectors-in-table-cell
branch
from
190dcf7 to
0899140
Compare
langz
approved these changes
Feb 2, 2023
tujoworker
deleted the
revert-1902-chore/remove-deprecated-selectors-in-table-cell
branch
tujoworker
added a commit
that referenced
this pull request
Feb 5, 2023
tujoworker
added a commit
that referenced
this pull request
Feb 7, 2023
tujoworker
added a commit
that referenced
this pull request
Feb 9, 2023
tujoworker
added a commit
that referenced
this pull request
Feb 11, 2023
langz
pushed a commit
that referenced
this pull request
Feb 22, 2023
langz
pushed a commit
that referenced
this pull request
Feb 22, 2023
tujoworker
pushed a commit
that referenced
this pull request
Feb 23, 2023
# [9.48.0-beta.1](v9.47.1...v9.48.0-beta.1) (2023-02-23) ### Bug Fixes * **Anchor:** comments Anchor's inner_ref usage ([#1919](#1919)) ([7653316](7653316)) * **Autocomplete:** pass status props to SubmitButton ([#2004](#2004)) ([fb89114](fb89114)) * **Badge:** enhance semantic / accessibility and inherit skeleton from provider ([#1967](#1967)) ([5a870a7](5a870a7)) * **Button:** remove left and right padding of tertiary button ([5919c79](5919c79)) * **Button:** support rel property ([#1990](#1990)) ([ad029f2](ad029f2)) * **Dl:** ensure horizontal wrap no matter what available space ([#1965](#1965)) ([ab15893](ab15893)) * fix breadcumb alignment after tertiary button changes ([2989af1](2989af1)) * fix pagination alignment after tertiary button changes ([ce6e5ea](ce6e5ea)) * **InfoCard:** enhance accessibility + set max width of 60ch ([#1977](#1977)) ([5a4f344](5a4f344)) * remove `maintained node versions` from .browserslistrc ([#1917](#1917)) ([9cb43c4](9cb43c4)), closes [#1912](#1912) * **Timeline:** use ordered list element ([#1962](#1962)) ([2b77b8e](2b77b8e)) * upgrade Stylelint from v13 to v15 ([#1995](#1995)) ([21a1cdb](21a1cdb)) * remove web components and vue support (#1946) ([baa4ca3](baa4ca3)), closes [#1946](#1946) * re-define Media Query Breakpoints and layout width (#1373) ([73d1b77](73d1b77)), closes [#1373](#1373) * v10 ([514becd](514becd)) ### Features * **Anchor:** deprecate property target_blank_title ([#1882](#1882)) ([8c6448d](8c6448d)) * build pure component css packages (without deps) ([#1928](#1928)) ([5a7e111](5a7e111)) * **build:** replace node-sass with dart-sass ([#1934](#1934)) ([ba3fed2](ba3fed2)) * **Checkbox:** deprecate default_state property ([#1863](#1863)) ([e5fb21e](e5fb21e)) * deprecate StepIndicator v1 ([#1840](#1840)) ([c0d9518](c0d9518)) * **DrawerList:** remove use_drawer_on_mobile & enable_closest_observer ([#1879](#1879)) ([e56c925](e56c925)) * **Dropdown:** remove deprecated selected_item property ([#1870](#1870)) ([5321b3a](5321b3a)) * **Element:** deprecate css, class, inner_ref, skeleton_method ([#1859](#1859)) ([7b9554d](7b9554d)) * **FormRow:** remove indent feature ([#1975](#1975)) ([5c58e39](5c58e39)) * **FormStatus:** remove deprecated status property ([#1914](#1914)) ([3c867b5](3c867b5)) * **GlobalStatus:** deprecate AddStatus & Set ([#1891](#1891)) ([bf382fd](bf382fd)) * **H:** deprecate is and style_type properties ([#1856](#1856)) ([c9fb5a6](c9fb5a6)) * **Helpers:** deprecate .dnb-sr-only--inline & .dnb-not-sr-only ([#1865](#1865)) ([d84a49f](d84a49f)) * include all type definitions in repo ([#1996](#1996)) ([3a93c5a](3a93c5a)) * **InputMasked:** ATTENTION! make allowLeadingZeroes default to true ([#1126](#1126)) ([bb2edca](bb2edca)) * **Modal, Dialog, Drawer:** remove closeButtonAttributes ([#1926](#1926)) ([82cd99d](82cd99d)) * **Modal:** remove deprecated mode prop ([#1993](#1993)) ([86c8adc](86c8adc)) * **Modal:** remove deprecated trigger_ props ([#1918](#1918)) ([2eced1b](2eced1b)) * new browserslist config for es6 builds ([#1833](#1833)) ([ab57b84](ab57b84)) * **Number:** Removes component ([#1924](#1924)) ([aeaadc0](aeaadc0)) * **P:** deprecate style_type property ([#1855](#1855)) ([74bc0ea](74bc0ea)) * **P:** remove deprecated class dnb-p--ingress ([#1872](#1872)) ([04e4632](04e4632)) * remove support for internet explorer ([#1807](#1807)) ([fbfd636](fbfd636)) * replace visual test driver to jest-image-snapshot and Firefox (Playwright) ([#1945](#1945)) ([fcc9348](fcc9348)), closes [/github.com/puppeteer/puppeteer/issues/7514#issuecomment-1005917527](https://github.com//github.com/puppeteer/puppeteer/issues/7514/issues/issuecomment-1005917527) [/github.com/dnbexperience/eufemia/blob/88279d1e6903497fce40d6c4322dd9b7c7b9ac3b/packages/dnb-eufemia/src/core/jest/jestSetupScreenshots.js#L39](https://github.com//github.com/dnbexperience/eufemia/blob/88279d1e6903497fce40d6c4322dd9b7c7b9ac3b/packages/dnb-eufemia/src/core/jest/jestSetupScreenshots.js/issues/L39) * **ScrollView:** add interactive=auto to observe the content ([#1984](#1984)) ([988390c](988390c)) * **Section:** deprecate style_type signal-orange ([#1886](#1886)) ([661d976](661d976)) * **SkipContent:** add new component to skip large contents when using tab key ([#1981](#1981)) ([c44ef28](c44ef28)) * **Slider:** deprecate use_scrollwheel ([#1889](#1889)) ([639df46](639df46)) * **Slider:** remove deprecated onInit prop ([#1909](#1909)) ([0595a53](0595a53)) * **Slider:** remove dnb-range styling ([#1890](#1890)) ([1d2693c](1d2693c)) * **Space:** add conditional reset class: `dnb-space__reset` ([#1961](#1961)) ([a79bb2a](a79bb2a)) * **SpacingUtils:** deprecate createStyleObject ([#1892](#1892)) ([cadf378](cadf378)) * **Switch:** deprecate default_state property ([#1864](#1864)) ([da2c568](da2c568)) * **Table:** deprecate sticky_offset ([#1883](#1883)) ([5a242a1](5a242a1)) * **Tags:** removed deprecated comments ([#1857](#1857)) ([9af5268](9af5268)) * **Timeline:** deprecate name and date props ([#1884](#1884)) ([a95db13](a95db13)) * **Typography:** removed deprecated comments ([#1858](#1858)) ([1fd2b48](1fd2b48)) ### Reverts * Revert "chore(Table): remove deprecated selectors (#1902)" (#1968) ([b43bb4f](b43bb4f)), closes [#1902](#1902) [#1968](#1968) ### BREAKING CHANGES * **Modal:** - Modal: Remove deprecated `mode` prop – it will default to `custom` mode. Use rather the `Dialog` or the `Drawer` component. * Remove support for Web Components and Vue * re-define Media Query Breakpoints and layout width * Read the docs about migration: https://eufemia.dnb.no/uilib/about-the-lib/releases/eufemia/v10-info
tujoworker
added a commit
that referenced
this pull request
Feb 23, 2023
tujoworker
added a commit
that referenced
this pull request
Feb 23, 2023
joakbjerk
pushed a commit
that referenced
this pull request
Mar 27, 2023
langz
pushed a commit
that referenced
this pull request
May 31, 2023
tujoworker
added a commit
that referenced
this pull request
May 31, 2023
tujoworker
added a commit
that referenced
this pull request
May 31, 2023
tujoworker
added a commit
that referenced
this pull request
May 31, 2023
tujoworker
added a commit
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1902
I rethought the decision. And I think, we should still support basic table styles, without classes, as long as the table element is declared with
.dnb-table.