fix(Anchor): allow rel property in TS #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langz
force-pushed
the
fix/use-HTMLProps-instead-of-HTMLAttributes
branch
from
fcb6423 to
4d3c790
Compare
langz
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dc06c80:
|
tujoworker
approved these changes
Jan 4, 2023
|
Do you found the commit that made the change (from prev version) by the way? |
#1715 and the change https://github.com/dnbexperience/eufemia/pull/1715/files#diff-69edde89b21515b1a726d1403a98b761a9f6aeb488366bb84ea5ef565102c47aR36, I think. |
✅ DNB Eufemia Portal deploy preview ready
|
langz
force-pushed
the
fix/use-HTMLProps-instead-of-HTMLAttributes
branch
from
4d3c790 to
dc06c80
Compare
tujoworker
pushed a commit
that referenced
this pull request
Jan 4, 2023
## [9.45.1](v9.45.0...v9.45.1) (2023-01-04) ### Bug Fixes * **Anchor:** allow rel property in TS ([#1849](#1849)) ([e3b1be1](e3b1be1))
|
🎉 This PR is included in version 9.45.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
joakbjerk
pushed a commit
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like
HTMLPropsincludes more props thanHTMLAttributes,relbeing one of them.Or maybe we should use
React.ComponentPropsWithoutRef<"a">? 🤔https://github.com/typescript-cheatsheets/react/blob/main/docs/advanced/patterns_by_usecase.md#componentprops