-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Space): rewrite Space component to TypeScript #1644
Conversation
✅ DNB Eufemia Portal deploy preview ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 💯
Seems to be a few minor TS errors popping up, that we have to fix 🔨
But that's just nice, shows that TS works, forcing us to use the correct types 🙏
08852e9
to
19703a2
Compare
19703a2
to
80b2742
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 80b2742:
|
# [9.33.0](v9.32.1...v9.33.0) (2022-10-23) ### Bug Fixes * **Accordion:** replace internal animation with HeightAnimation component ([#1619](#1619)) ([2cb2d48](2cb2d48)) * **Dl:** ensure correct spacing ([#1626](#1626)) ([5330e6d](5330e6d)) * **Dl:** remove span as direct sibling for horizontal direction ([#1625](#1625)) ([6845219](6845219)) * **Drawer:** ensure ScrollView is used for scrollable content ([#1632](#1632)) ([fea2358](fea2358)) * **DrawerList:** fix auto sizing when used in Drawer component ([#1634](#1634)) ([f19d58b](f19d58b)), closes [#1632](#1632) [#1633](#1633) [#1631](#1631) * **DrawerList:** reset "enable_body_lock" handlers after closing ([#1629](#1629)) ([1a90c72](1a90c72)) * **Drawer:** make spacing of header and nav robust ([#1641](#1641)) ([5454ded](5454ded)) * **FormStatus:** fix stretch when used in Dropdown and Autocomplete ([#1618](#1618)) ([a961feb](a961feb)) * **gatsby-plugin-eufemia-theme-handler:** support Gatsby > v4.24 ([#1623](#1623)) ([34d0f6c](34d0f6c)) * **Icon:** fix override of data-testid property when provided ([#1637](#1637)) ([d335a14](d335a14)) * **Pagination:** fix locale support ([#1651](#1651)) ([01b93ce](01b93ce)) * **Section:** make style_type property accept any string ([#1636](#1636)) ([9e51565](9e51565)) * **Section:** rename AllSectionProps to SectionAllProps ([#1640](#1640)) ([23de874](23de874)) * **Space:** rewrite Space component to TypeScript ([#1644](#1644)) ([c59f732](c59f732)) * **Tooltip:** ensure timers cleanup on unmount ([#1642](#1642)) ([6dd4b7b](6dd4b7b)) ### Features * **DrawerList:** animate max-height when changed during scrolling ([#1631](#1631)) ([cf302f7](cf302f7)) * **DrawerList:** animate position when used inside dnb-scroll-view ([#1633](#1633)) ([7ed9550](7ed9550)) * **HeightAnimation:** add showOverflow property ([#1627](#1627)) ([a9bbce4](a9bbce4)) * **HeightAnimation:** make the view open by default ([#1646](#1646)) ([32aa0eb](32aa0eb)) * **icons:** hierarchy, layout_card and unlock ([#1654](#1654)) ([d8d37ba](d8d37ba)) * **Upload:** add new Upload component ([#1581](#1581)) ([3304347](3304347)), closes [#1626](#1626)
🎉 This PR is included in version 9.33.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.