Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): ensure dnb-input--null class will not be set #1544

Merged
merged 2 commits into from
Aug 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ exports[`Autocomplete markup have to match snapshot 1`] = `
value="CC cc"
>
<span
className="dnb-input dnb-input--null dnb-form-component dnb-autocomplete__input dnb-input--icon-position-null dnb-input--has-icon dnb-input--icon-size-icon_size dnb-input--has-submit-element dnb-input__status--error"
className="dnb-input dnb-form-component dnb-autocomplete__input dnb-input--icon-position-null dnb-input--has-icon dnb-input--icon-size-icon_size dnb-input--has-submit-element dnb-input__status--error"
data-has-content="true"
data-input-state="virgin"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ exports[`DatePicker component have to match snapshot 1`] = `
value="initval"
>
<span
className="dnb-input dnb-input--text dnb-form-component dnb-input--has-submit-element dnb-input__status--error"
className="dnb-input dnb-form-component dnb-input--text dnb-input--has-submit-element dnb-input__status--error"
data-has-content="false"
data-input-state="virgin"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ exports[`InputMasked component have to match type="text" snapshot 1`] = `
value="test"
>
<span
className="dnb-input dnb-input--text dnb-form-component dnb-input-masked"
className="dnb-input dnb-form-component dnb-input-masked dnb-input--text"
data-has-content="true"
data-input-state="virgin"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/dnb-eufemia/src/components/input/Input.js
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ export default class Input extends React.PureComponent {
const mainParams = {
className: classnames(
'dnb-input',
`dnb-input--${type}`, //type_modifier
type && `dnb-input--${type}`,
size && !sizeIsNumber && `dnb-input--${size}`,
hasSubmitButton && 'dnb-input--has-submit-element',
isTrue(clear) && 'dnb-input--has-clear-button',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ exports[`Input component have to match type="search" snapshot 1`] = `
value="test"
>
<span
className="dnb-input dnb-input--search dnb-form-component dnb-input--has-submit-element"
className="dnb-input dnb-form-component dnb-input--search dnb-input--has-submit-element"
data-has-content="true"
data-input-state="virgin"
>
Expand Down Expand Up @@ -649,7 +649,7 @@ exports[`Input component have to match type="text" snapshot 1`] = `
value="test"
>
<span
className="dnb-input dnb-input--text dnb-form-component"
className="dnb-input dnb-form-component dnb-input--text"
data-has-content="true"
data-input-state="virgin"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ exports[`InputPassword component have to match snapshot 1`] = `
value="test"
>
<span
className="dnb-input dnb-input--password dnb-form-component dnb-input--password dnb-input--has-submit-element"
className="dnb-input dnb-form-component dnb-input--password dnb-input--password dnb-input--has-submit-element"
data-has-content="true"
data-input-state="virgin"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ exports[`Skeleton component have to match snapshot 1`] = `
value="initval"
>
<span
className="dnb-input dnb-input--text dnb-form-component"
className="dnb-input dnb-form-component dnb-input--text"
data-has-content="true"
data-input-state="virgin"
>
Expand Down