Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Lists): add Definition List example using CSS Grid #1525

Closed
wants to merge 1 commit into from

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Aug 24, 2022

The question is, should this be possible to achieve within the "component", without having these CSS lines? I think so as of now. Will have to check with UX.

The only thing is the "minimum width" that should be editable.

Screenshot 2022-08-24 at 15 31 28

@tujoworker tujoworker requested a review from AadneRo August 24, 2022 13:32
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 24, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5c53c17:

Sandbox Source
eufemia-starter Configuration

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 24, 2022

Gatsby Cloud Build Report

DNB Eufemia Portal

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 12m

Performance

Lighthouse report

Metric Score
Performance 🔶 70
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 92

🔗 View full report

AadneRo
AadneRo previously approved these changes Aug 29, 2022
Copy link
Contributor

@AadneRo AadneRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the Remove list styles appear twice in the portal. Unless there is something I missed

@AadneRo AadneRo self-requested a review August 29, 2022 08:07
@tujoworker
Copy link
Member Author

appear twice in the portal

OMG, they are! 🫣 Thank You 🙏

@tujoworker
Copy link
Member Author

Closing this PR in favor of #1536

@tujoworker tujoworker closed this Aug 30, 2022
@tujoworker tujoworker deleted the docs/definition-lists-example branch March 7, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants