Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Autocomplete): Missing properties in PropTypes #1383

Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix(Autocomplete): Missing properties in PropTypes #1383

merged 1 commit into from
Apr 6, 2022

Conversation

langz
Copy link
Contributor

@langz langz commented Apr 1, 2022 •
edited
Loading

Fixes the following warning when running yarn build:types:

✖ The property "enable_body_lock" is not defined in PropTypes!
Component: Autocomplete
File: ./src/components/autocomplete/Autocomplete.js


✖ The property "min_height" is not defined in PropTypes!
Component: Autocomplete
File: ./src/components/autocomplete/Autocomplete.js


✖ The property "page_offset" is not defined in PropTypes!
Component: Autocomplete
File: ./src/components/autocomplete/Autocomplete.js


✖ The property "observer_element" is not defined in PropTypes!
Component: Autocomplete
File: ./src/components/autocomplete/Autocomplete.js

@langz langz force-pushed the fix/missing-properties-in-proptypes-of-autocomplete branch from f000542 to 871893c Compare April 1, 2022 10:49
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 1, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 558d4ce:

Sandbox Source
eufemia-starter Configuration

@langz langz force-pushed the fix/missing-properties-in-proptypes-of-autocomplete branch from 871893c to 558d4ce Compare April 1, 2022 10:58
@gatsby-cloud
Copy link

gatsby-cloud bot commented Apr 1, 2022 •
edited
Loading

Gatsby Cloud Build Report

DNB Eufemia Portal

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 10m

Performance

Lighthouse report

Metric Score
Performance 🔶 66
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 92

🔗 View full report

@tujoworker tujoworker self-requested a review April 4, 2022 13:19
tujoworker
tujoworker approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙌

@langz langz merged commit 1256009 into main Apr 6, 2022
@langz langz deleted the fix/missing-properties-in-proptypes-of-autocomplete branch April 6, 2022 07:01
tujoworker pushed a commit that referenced this pull request Apr 27, 2022
@semantic-release-bot
chore(release): 9.26.0 [skip ci]
8a37584 
# [9.26.0](v9.25.0...v9.26.0) (2022-04-27)

### Bug Fixes

* **Autocomplete:** Missing properties in PropTypes ([#1383](#1383)) ([1256009](1256009))
* **HelpButton:** ensure Drawer/Dialog/Modal trigger button gets a label ([4b52c98](4b52c98))

### Features

* add "plain" variant to Accordion ([#1398](#1398)) ([105d9ae](105d9ae))
* make Accordion support a separate icon for the expanded state ([58ac1d3](58ac1d3))
@tujoworker
Copy link
Member

🎉 This PR is included in version 9.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tujoworker tujoworker tujoworker approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langz @tujoworker