Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tag): add default spacing 8px between tags #1266

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Conversation

dinarosv
Copy link
Contributor

@dinarosv dinarosv commented Feb 4, 2022

Added default spacing between Tags in a Tag group and removed the clickable tag demo

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 17c848f:

Sandbox Source
eufemia-starter Configuration

@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 4, 2022

Gatsby Cloud Build Report

DNB Eufemia Portal

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 9m

Performance

Lighthouse report

Metric Score
Performance 🔶 64
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 92

🔗 View full report

Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good 🙏

Copy link
Contributor

@thaytharma thaytharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌🏼

@dinarosv dinarosv merged commit 740afeb into main Feb 4, 2022
@dinarosv dinarosv deleted the fix/tag-spacing branch February 4, 2022 09:37
tujoworker pushed a commit that referenced this pull request Feb 4, 2022
# [9.21.0](v9.20.0...v9.21.0) (2022-02-04)

### Bug Fixes

* **Breadcrumb:** fix typo in snapshot test ([#1258](#1258)) ([df4e17c](df4e17c))
* **Tag:** add default spacing 8px between tags ([#1266](#1266)) ([740afeb](740afeb))

### Features

* **Tag:** add skeleton example ([#1263](#1263)) ([52e05d8](52e05d8))
@tujoworker
Copy link
Member

🎉 This PR is included in version 9.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants