feat(Forms): add variant="filled" and toolbarVariant="custom" to Iterate.EditContainer and Iterate.ViewContainer
#4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
langz
reviewed
Nov 22, 2024
packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx
Outdated
Show resolved
Hide resolved
langz
reviewed
Nov 22, 2024
packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Iterate/Array/demos.mdx
Outdated
Show resolved
Hide resolved
tujoworker
force-pushed
the
feat/forms-iterate-container-variant
branch
2 times, most recently
from
062874c to
bc46bf3
Compare
tujoworker
force-pushed
the
feat/forms-iterate-container-variant
branch
from
bc46bf3 to
7dd024f
Compare
tujoworker
changed the title
variant="filled" and toolbarVariant="basic" to Iterate.EditContainer and Iterate.ViewContainervariant="filled" and toolbarVariant="custom" to Iterate.EditContainer and Iterate.ViewContainer
tujoworker
force-pushed
the
feat/forms-iterate-container-variant
branch
from
7dd024f to
e6aa3dd
Compare
…ate.ViewContainer
tujoworker
force-pushed
the
feat/forms-iterate-container-variant
branch
from
e6aa3dd to
e5fef3d
Compare
langz
approved these changes
Nov 25, 2024
tujoworker
pushed a commit
that referenced
this pull request
Nov 29, 2024
## [10.58.0](v10.57.1...v10.58.0) (2024-11-29) ### ✨ Features * **Forms:** add `showConfirmDialog` to Iterate.RemoveButton ([#4330](#4330)) ([76bddf0](76bddf0)) * **Forms:** add `variant="filled"` and `toolbarVariant="custom"` to Iterate.EditContainer and Iterate.ViewContainer ([#4329](#4329)) ([b2b9eef](b2b9eef)) * **Forms:** add support for using a function references instead of a string based id ([#4331](#4331)) ([a6e3bc3](a6e3bc3)) * **Forms:** enhance typing and add docs on how to deal with TypeScript types ([#4343](#4343)) ([10b199b](10b199b)) * **Forms:** introduce `decoupleForm` prop to Form.Handler ([#4332](#4332)) ([0b02b6e](0b02b6e)) ### 🐛 Bug Fixes * **DatePicker:** make sure the picker and input only reacts to the props that have changed ([#4342](#4342)) ([4cd52a3](4cd52a3)) * **Forms.Card:** remove outline when variant="basic" on Section containers when used in Wizard ([#4336](#4336)) ([ebad212](ebad212)) * **forms:** add `sessionStorageId` support to Field.Upload with empty file list rendering ([#4339](#4339)) ([d02a0af](d02a0af)) * **NumberFormat:** improve regex for parsing phone numbers with country codes ([#4340](#4340)) ([96613ed](96613ed)), closes [#4337](#4337)
|
🎉 This PR is included in version 10.58.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement the needs explained in this PR #4229
We introduce two new values/variants:
variant="filled"will render the view and edit container with a background color.toolbarVariant="custom"will render the given toolbar without any spacing so you can customize it to your needs.Here is a PR Preview.
Some screenshots
The ViewContainer:
The EditContainer: