Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Logo): Refactor Logo to ts #3611

Merged
merged 9 commits into from
Jun 6, 2024
Merged

feat(Logo): Refactor Logo to ts #3611

merged 9 commits into from
Jun 6, 2024

Conversation

AadneRo
Copy link
Contributor

@AadneRo AadneRo commented May 27, 2024

  • Refactor the Logo component to typescript
  • Add deprecated tag to wrongly cased components and unused components
  • Add typed docs

Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 8:33am

@AadneRo AadneRo force-pushed the chore/migrate-logo-to-ts branch 2 times, most recently from dbe9edb to 88b70cf Compare May 27, 2024 11:51
Copy link

codesandbox-ci bot commented May 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@AadneRo AadneRo changed the title Chore(Logo): Refactor Logo to ts chore(Logo): Refactor Logo to ts May 27, 2024
@tujoworker tujoworker changed the title chore(Logo): Refactor Logo to ts feat(Logo): Refactor Logo to ts May 28, 2024
@AadneRo AadneRo force-pushed the chore/migrate-logo-to-ts branch from 88b70cf to 5613e18 Compare May 28, 2024 10:44
@AadneRo AadneRo force-pushed the chore/migrate-logo-to-ts branch 2 times, most recently from 41bb082 to 944f92d Compare May 28, 2024 11:05
@AadneRo AadneRo force-pushed the chore/migrate-logo-to-ts branch from 944f92d to 64d7e5a Compare May 29, 2024 07:01
@AadneRo AadneRo force-pushed the chore/migrate-logo-to-ts branch from e988134 to 88a141d Compare May 30, 2024 07:55
@tujoworker tujoworker self-requested a review June 4, 2024 08:26
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

packages/dnb-eufemia/src/shared/locales/en-GB.ts Outdated Show resolved Hide resolved
packages/dnb-eufemia/src/shared/locales/nb-NO.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I just came up with two minor suggestions/improvements when I read through the PR.
Nothing you actually made changes too 😹

packages/dnb-eufemia/src/components/logo/Logo.tsx Outdated Show resolved Hide resolved
packages/dnb-eufemia/src/components/logo/Logo.tsx Outdated Show resolved Hide resolved
AadneRo and others added 5 commits June 6, 2024 10:13
- Refactor the Logo component
- Add deprecated tag to wrongly cased components and unused components
- Add typed docs
@tujoworker tujoworker force-pushed the chore/migrate-logo-to-ts branch from 06d6b64 to 6d57e98 Compare June 6, 2024 08:13
@tujoworker tujoworker force-pushed the chore/migrate-logo-to-ts branch from 6d57e98 to ced8eeb Compare June 6, 2024 08:14
@AadneRo AadneRo merged commit b1ca771 into main Jun 6, 2024
9 checks passed
@AadneRo AadneRo deleted the chore/migrate-logo-to-ts branch June 6, 2024 09:58
AadneRo added a commit that referenced this pull request Jun 7, 2024
The size prop was broken in earlier refactor to ts (#3611). This fix
makes it backwards compatible.

---------

Co-authored-by: Tobias Høegh <[email protected]>
tujoworker pushed a commit that referenced this pull request Jun 11, 2024
## [10.35.0](v10.34.1...v10.35.0) (2024-06-11)

### 📝 Documentation

* add link to Eufemia's GitHub repository in menu bar ([#3670](#3670)) ([cdecbb3](cdecbb3))
* fix heading levels ([#3660](#3660)) ([d0bb28d](d0bb28d))
* **Forms:** fix broken link to forms/Wizard/Container ([#3656](#3656)) ([53cb041](53cb041))
* **Forms:** reqruied -> required ([#3655](#3655)) ([be82a51](be82a51))
* remove demos ([#3668](#3668)) ([90638ce](90638ce))

### 🐛 Bug Fixes

* add support for ::selection color for Chromium based browsers ([#3689](#3689)) ([6e49a9b](6e49a9b))
* **forms:** add help button to Field.Option ([#3678](#3678)) ([9210281](9210281))
* **forms:** ensure help button is rendered only once in Toggle and Boolean fields ([#3675](#3675)) ([d9e9478](d9e9478))
* **forms:** solve issue when schema is used in Wizard ([#3680](#3680)) ([8699b0c](8699b0c))
* **TextCounter:** exceeded message when variant up ([#3688](#3688)) ([22f1507](22f1507))

### ✨ Features

* **assets:** add sbanken logo svgs ([#3674](#3674)) ([1d7bcc0](1d7bcc0))
* **filter:** add support to filter array data based on wildcard `*` ([#3679](#3679)) ([1d93ac4](1d93ac4))
* **forms:** add edit and view containers to `Form.Section` ([#3652](#3652)) ([51bf7a2](51bf7a2))
* **forms:** add help property to ArraySelection field ([#3694](#3694)) ([f6b1224](f6b1224))
* **HelpButton:** ensure larger bounding area when size is set to small ([#3677](#3677)) ([97ca056](97ca056))
* **Logo:** Refactor Logo to ts ([#3611](#3611)) ([b1ca771](b1ca771))
* **NumberFormat:** add monospace support ([#3669](#3669)) ([940ddb6](940ddb6))
* refactor internal translation logic to not mutate the root context ([#3691](#3691)) ([49b0b45](49b0b45))
* **Table:** added handle to collapse all accordion rows ([#3666](#3666)) ([c09a697](c09a697))
* **Translation:** add support for type-safe keys ([#3681](#3681)) ([437ba83](437ba83))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants