Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FormStatus, Section): change sbanken info color to purple #3589

Merged
merged 5 commits into from
Jun 2, 2024

Conversation

snorrekim
Copy link
Contributor

@snorrekim snorrekim commented May 22, 2024

  • Fix colors for sbanken <FormStatus> icons
  • Sbanken info <FormStatus> now have the same color at marketing
  • Update other uses of the "info" status style
  • <Breadcrumb> now use custom background color in sbanken theme

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 2:43pm

@snorrekim snorrekim changed the title feat(FormStatus,Section): change sbanken info color to purple feat(FormStatus, Section): change sbanken info color to purple May 22, 2024
Copy link

codesandbox-ci bot commented May 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work. My only suggestion is to either import the hex colors from properties.js or use CSS vars. See extra comment/suggestion, which would count for all the other places where a hex value is used.

@tujoworker tujoworker merged commit 5356eb8 into main Jun 2, 2024
10 checks passed
@tujoworker tujoworker deleted the feat/form-status-sbanken-info-color branch June 2, 2024 20:07
tujoworker pushed a commit that referenced this pull request Jun 3, 2024
## [10.34.0](v10.33.0...v10.34.0) (2024-06-03)

### 🐛 Bug Fixes

* **DrawerList:** prevent call attempt for word if not function ([#3613](#3613)) ([66e04ba](66e04ba))
* **forms:** add align prop to Field.Composition ([#3622](#3622)) ([b8cfcd4](b8cfcd4))
* **forms:** enhance handling of schema TypeScript support ([#3635](#3635)) ([8e09651](8e09651)), closes [#3621](#3621)
* **forms:** ensure Value.Number renders with 0 ([#3620](#3620)) ([9f4a4d3](9f4a4d3))
* **TableContainer:** take full width when inside `Card` ([#3630](#3630)) ([c4d5c14](c4d5c14))

### ✨ Features

* **Autocomplete:** preliminary sbanken colors ([#3604](#3604)) ([fe42538](fe42538))
* **Blocks:** add ChildrenWithAge block ([#3619](#3619)) ([118932c](118932c))
* **Card:** stretch content inside when `stack` is true ([#3633](#3633)) ([d9177e9](d9177e9))
* **Checkbox, Radio:** fix border width for Sbanken brand ([#3612](#3612)) ([624ecf2](624ecf2))
* **forms:** add `active` prop to Wizard.Step ([#3639](#3639)) ([2804041](2804041))
* **forms:** add `countPath` prop to Iterate.Array ([#3615](#3615)) ([dfe96f5](dfe96f5))
* **forms:** add `defaultValue` to all `Value.*` components ([#3627](#3627)) ([4fdc778](4fdc778))
* **forms:** add `defaultValue` to all fields ([#3616](#3616)) ([58d698a](58d698a)), closes [#3615](#3615)
* **forms:** add `trueText` and `falseText` to Value.Boolean ([#3624](#3624)) ([c9cae37](c9cae37))
* **forms:** add hr to Wizard.EditButton ([#3637](#3637)) ([2018d16](2018d16))
* **forms:** add minimum and maximum to Value.Number ([#3636](#3636)) ([bbe3b2b](bbe3b2b))
* **forms:** add startWith prop to Field.Number ([#3632](#3632)) ([b6d177a](b6d177a))
* **FormStatus, Section:** change sbanken info color to purple ([#3589](#3589)) ([5356eb8](5356eb8))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants