Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(Field.Boolean): value does not display which value is selected when field is disabled and variant is buttons #3027

Closed
langz opened this issue Dec 8, 2023 · 0 comments · Fixed by #3224
Closed

bug(Field.Boolean): value does not display which value is selected when field is disabled and variant is buttons #3027

langz opened this issue Dec 8, 2023 · 0 comments · Fixed by #3224
Assignees
@joakbjerk
Labels
bug Something isn't working
Milestone
Forms Issue

Comments

@langz
Copy link
Contributor

langz commented Dec 8, 2023 •
edited
Loading

🐛 Bug Report

In the light of the following two CSBs:

It's observed that the following code does not display which value that's selected/used:

      <Field.Boolean
        value={true}
        path="/boolean3"
        label="Boolean buttons"
        variant="buttons"
        disabled
      />

Results in:
image

To Reproduce

CSB with a reproduction
@langz langz mentioned this issue Dec 8, 2023
Closed
@langz langz added the bug Something isn't working label Dec 8, 2023
@langz langz added this to the Forms Release milestone Dec 8, 2023
@joakbjerk joakbjerk mentioned this issue Jan 15, 2024
Merged
@joakbjerk joakbjerk self-assigned this Jan 15, 2024
@joakbjerk joakbjerk linked a pull request Jan 16, 2024 that will close this issue
fix(ToggleButton): add checked disabled style #3224
Merged
tujoworker added a commit that referenced this issue Jan 16, 2024
@joakbjerk @tujoworker
fix(ToggleButton): add checked disabled style (#3224)
c3ea6a6 
proposal to solve #3028
and #3027

Not sure if its the best way though.

before:
<img width="143" alt="Screenshot 2024-01-15 at 10 12 42"
src="https://github.com/dnbexperience/eufemia/assets/25927156/3f08ba85-8f75-444d-bf4f-8fe8b918c9d6">

after:
<img width="166" alt="Screenshot 2024-01-15 at 10 12 22"
src="https://github.com/dnbexperience/eufemia/assets/25927156/48d84173-a76e-4317-9634-194d349a88ed">

---------

Co-authored-by: Tobias Høegh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakbjerk joakbjerk

Labels
bug Something isn't working
Milestone
Forms Issue
Development

Successfully merging a pull request may close this issue.

fix(ToggleButton): add checked disabled style dnbexperience/eufemia
2 participants
@langz @joakbjerk