Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PhoneNumber): Sort country codes by display language #2862

Closed
joakbjerk opened this issue Nov 7, 2023 · 1 comment · Fixed by #2852
Closed

(PhoneNumber): Sort country codes by display language #2862

joakbjerk opened this issue Nov 7, 2023 · 1 comment · Fixed by #2852
Labels
released

Comments

@joakbjerk
Copy link
Contributor

joakbjerk commented Nov 7, 2023 •
edited
Loading

🚀 Feature Proposal

As of today, the country codes in the autocomplete-dropdown are sorted by iso and not the i18n values used to display the country.

Screen.Recording.2023-11-07.at.14.20.29.mov

Motivation

Make it easier and more logical for the user to look for country codes when scrolling through the dropdown. Going from A to Ø(sterrike) and then suddenly H(viterussland) is a tad confusing.

Example

The user would scroll through the list and find the country codes sorted alphabetically by the display names shown to the user, instead of the iso-value

Pitch

Seems like good UX.
@joakbjerk joakbjerk changed the title Sort country codes by display language (PhoneNumber): Sort country codes by display language Nov 7, 2023
@tujoworker tujoworker mentioned this issue Nov 7, 2023
Merged
tujoworker added a commit that referenced this issue Nov 9, 2023
@langz @tujoworker
fix(PhoneNumber): ensure correct selection of value (#2852)
a20a764 
Added a test for the issue
#2850

Not 100% sure about the actual fix yet 🤔 
If someone else has a clue, please give it a go, and add a commit to
this branch 🙇

---

Update:

- This PR relies on PR #2863
- Fixes #2862 and #2850

Co-authored-by: Tobias Høegh <[email protected]>
@tujoworker
Copy link
Member

🎉 This issue has been resolved in version 10.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(PhoneNumber): ensure correct selection of value dnbexperience/eufemia
2 participants
@tujoworker @joakbjerk