feat(Button): sbanken hover and error #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cccf829:
|
snorrekim
force-pushed
the
feat/button-sbanken-hover
branch
from
483c1d0 to
27709af
Compare
snorrekim
changed the title
snorrekim
force-pushed
the
feat/button-sbanken-hover
branch
from
206f7b6 to
4de5c5c
Compare
snorrekim
force-pushed
the
feat/button-sbanken-hover
branch
from
fb3411e to
8d7def6
Compare
snorrekim
force-pushed
the
feat/button-sbanken-hover
branch
2 times, most recently
from
4dfa98a to
71d12fe
Compare
snorrekim
force-pushed
the
feat/button-sbanken-hover
branch
from
71d12fe to
ed40653
Compare
snorrekim
force-pushed
the
feat/button-sbanken-hover
branch
2 times, most recently
from
627b355 to
90e25d8
Compare
snorrekim
force-pushed
the
feat/button-sbanken-hover
branch
from
90e25d8 to
8d7def6
Compare
snorrekim
force-pushed
the
feat/button-sbanken-hover
branch
from
8d7def6 to
6192291
Compare
snorrekim
force-pushed
the
feat/button-sbanken-hover
branch
from
6192291 to
cccf829
Compare
tujoworker
pushed a commit
that referenced
this pull request
Aug 17, 2023
## [10.6.0](v10.5.0...v10.6.0) (2023-08-17) ### 📝 Documentation * add "Messageboxes" to FormStatus for the equivalent Figma name ([#2560](#2560)) ([bf6a19f](bf6a19f)) * add docs on how to link to a specific theme ([#2555](#2555)) ([54b9f1b](54b9f1b)), closes [#2374](#2374) * add theming link to the contribution guide ([#2558](#2558)) ([e88bd72](e88bd72)) ### ✨ Features * **Anchor:** inline style sbanken ([#2550](#2550)) ([3511f09](3511f09)) * **Button:** sbanken hover and error ([#2523](#2523)) ([3ea2850](3ea2850)) * **Forms:** Extension (beta) for simplified implementation of web forms through tailored functionality for layout and data handling ([#2420](#2420)) ([74700c0](74700c0)) * **Input:** sbanken styling ([#2540](#2540)) ([db36f09](db36f09)) * **Textarea:** sbanken theme ([#2551](#2551)) ([d8cfb1c](d8cfb1c)) ### 🐛 Bug Fixes * **Forms:** fix circular imports issue ([#2566](#2566)) ([3ac4276](3ac4276)) * **NumberFormat:** accept options like maximumFractionDigits ([#2557](#2557)) ([2e09e80](2e09e80))
|
🎉 This PR is included in version 10.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Missing error button hover, active, focus styles?
The new error button screenshots uncovered that these buttons do not have their own style for hover, active, focus in DNB/Eiendom theme. They just look the same as a regular button when interacted with. I don't know if that is intended or not, but might be a bug. (Sbanken theme has styles for these states).