Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to link to docs of specific brand/theme? #2374

Closed
langz opened this issue May 25, 2023 · 2 comments · Fixed by #2555
Closed

How to link to docs of specific brand/theme? #2374

langz opened this issue May 25, 2023 · 2 comments · Fixed by #2555
Labels
released

Comments

@langz
Copy link
Contributor

langz commented May 25, 2023 •
edited
Loading

🚀 Feature Proposal

I would like to link the docs of a given component in a given brand/theme to other designers and devs. Sending a link like: https://eufemia.dnb.no/uilib/components/badge/demos?theme=dnbeiendom
Let's say that a designer is wondering how the anchor looks for brand/theme DNB Eiendom, I would want to be able to link it to him.

As of today, the person receiving the link would have to know to right click the "three dots" in the top right corner and "click change style theme" and select the correct theme.

Potential possible ways of solving this:

  • Using a query param?
  • When in the portal, we could a query param to the URL when user changes to any theme other than the default theme, so that the user quickly can copy the URL displayed in his browser's address bar and share it with his friends.
@tujoworker
Copy link
Member

This is possible 👍 we need to update the docs and mention the possibilities.

@tujoworker tujoworker mentioned this issue Aug 10, 2023
Merged
tujoworker added a commit that referenced this issue Aug 10, 2023
@tujoworker
docs: add docs on how to link to a specific theme (#2555)
54b9f1b 
Closes #2374
tujoworker pushed a commit that referenced this issue Aug 17, 2023
@semantic-release-bot
chore(release): 10.6.0 [skip ci]
73d2f21 
## [10.6.0](v10.5.0...v10.6.0) (2023-08-17)

### 📝 Documentation

* add "Messageboxes" to FormStatus for the equivalent Figma name ([#2560](#2560)) ([bf6a19f](bf6a19f))
* add docs on how to link to a specific theme ([#2555](#2555)) ([54b9f1b](54b9f1b)), closes [#2374](#2374)
* add theming link to the contribution guide ([#2558](#2558)) ([e88bd72](e88bd72))

### ✨ Features

* **Anchor:** inline style sbanken ([#2550](#2550)) ([3511f09](3511f09))
* **Button:** sbanken hover and error ([#2523](#2523)) ([3ea2850](3ea2850))
* **Forms:** Extension (beta) for simplified implementation of web forms through tailored functionality for layout and data handling ([#2420](#2420)) ([74700c0](74700c0))
* **Input:** sbanken styling ([#2540](#2540)) ([db36f09](db36f09))
* **Textarea:** sbanken theme ([#2551](#2551)) ([d8cfb1c](d8cfb1c))

### 🐛 Bug Fixes

* **Forms:** fix circular imports issue ([#2566](#2566)) ([3ac4276](3ac4276))
* **NumberFormat:** accept options like maximumFractionDigits ([#2557](#2557)) ([2e09e80](2e09e80))
@tujoworker
Copy link
Member

🎉 This issue has been resolved in version 10.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add docs on how to link to a specific theme dnbexperience/eufemia
2 participants
@langz @tujoworker