fix(Icon): fix override of data-testid property when provided

dnbexperience · Oct 13, 2022 · d623e75 · d623e75
1 parent 1a90c72
commit d623e75
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/dnb-eufemia/src/components/icon/Icon.js b/packages/dnb-eufemia/src/components/icon/Icon.js
@@ -353,11 +353,13 @@ export const prepareIcon = (props, context) => {
     title, // to show on hover, if defined
     ...attributes,
   })
+
   if (!alt && typeof wrapperParams['aria-hidden'] === 'undefined') {
     wrapperParams['aria-hidden'] = true
   }
   if (wrapperParams['aria-hidden']) {
     if (
+      !wrapperParams['data-testid'] &&
       typeof process !== 'undefined' &&
       process.env.NODE_ENV === 'test'
     ) {

diff --git a/packages/dnb-eufemia/src/components/icon/__tests__/Icon.test.js b/packages/dnb-eufemia/src/components/icon/__tests__/Icon.test.js
@@ -114,6 +114,22 @@ describe('Icon component', () => {
     ).toBe(false)
   })
 
+  it('should set a data-testid property', () => {
+    const Comp = mount(<Component icon={question} />)
+    expect(
+      Comp.find('span.dnb-icon').instance().getAttribute('data-testid')
+    ).toBe('SvgComponent icon')
+  })
+
+  it('should set the data-testid provided', () => {
+    const Comp = mount(
+      <Component icon={question} data-testid="custom-data-testid-value" />
+    )
+    expect(
+      Comp.find('span.dnb-icon').instance().getAttribute('data-testid')
+    ).toBe('custom-data-testid-value')
+  })
+
   it('should validate with ARIA rules', async () => {
     const Comp = mount(<Component {...props} />)
     expect(await axeComponent(Comp)).toHaveNoViolations()