fix(PhoneNumber): ensure correct selection

dnbexperience · Nov 8, 2023 · a404005 · a404005
1 parent d229ec2
commit a404005
Show file tree

Hide file tree

Showing 2 changed files with 82 additions and 15 deletions.
diff --git a/packages/dnb-eufemia/src/extensions/forms/Field/PhoneNumber/PhoneNumber.tsx b/packages/dnb-eufemia/src/extensions/forms/Field/PhoneNumber/PhoneNumber.tsx
@@ -20,6 +20,11 @@ export type Props = FieldHelpProps &
     width?: 'large' | 'stretch'
     onCountryCodeChange?: (value: string | undefined) => void
     onNumberChange?: (value: string | undefined) => void
+  } & {
+    /**
+     * For internal testing purposes
+     */
+    noAnimation?: boolean
   }
 
 function PhoneNumber(props: Props) {
@@ -68,18 +73,17 @@ function PhoneNumber(props: Props) {
       ? value.match(/^(\+[^ ]+)? ?(.*)$/)
       : [undefined, '', '']
 
-  const lang = sharedContext.locale?.split('-')[0]
-  const countryCodeData = useMemo(
-    () =>
-      countries.map((country) => ({
-        selectedKey: `+${country.cdc}`,
-        selected_value: `${country.iso} (+${country.cdc})`,
-        content: `+${country.cdc} ${
-          country.i18n[lang] ?? country.i18n.en
-        }`,
-      })),
-    [sharedContext.locale]
-  )
+  const getCountryData = ({ filter = null } = {}) => {
+    const lang = sharedContext.locale?.split('-')[0]
+    return countries
+      .filter(({ cdc }) => !filter || `+${cdc}` === filter)
+      .sort(({ i18n: a }, { i18n: b }) => (a[lang] > b[lang] ? 1 : -1))
+      .map((country) => makeObject(country, lang))
+  }
+
+  const singleCountryCodeData = useMemo(() => {
+    return getCountryData({ filter: countryCode })
+  }, [])
 
   const handleCountryCodeChange = useCallback(
     ({ data }: { data: { selectedKey: string } }) => {
@@ -111,6 +115,14 @@ function PhoneNumber(props: Props) {
     [countryCode, emptyValue, handleChange, onNumberChange]
   )
 
+  const onFocusHandler = ({ dataList, updateData }) => {
+    // because there can be more than one country with same cdc
+    if (dataList.length < 10) {
+      updateData(getCountryData())
+    }
+    handleFocus()
+  }
+
   return (
     <FieldBlock
       className={classnames('dnb-forms-field-phone-number', className)}
@@ -132,14 +144,16 @@ function PhoneNumber(props: Props) {
             countryCodeLabel ??
             sharedContext?.translation.Forms.countryCodeLabel
           }
-          data={countryCodeData}
+          mode="async"
+          data={singleCountryCodeData}
           value={countryCode}
           disabled={disabled}
-          on_focus={handleFocus}
+          on_focus={onFocusHandler}
           on_blur={handleBlur}
           on_change={handleCountryCodeChange}
           independent_width
           search_numbers
+          no_animation={props.noAnimation}
           stretch={width === 'stretch'}
         />
 
@@ -184,5 +198,21 @@ function PhoneNumber(props: Props) {
   )
 }
 
+type CountryType = {
+  cdc: string
+  iso: string
+  i18n: {
+    en: string
+  }
+}
+
+function makeObject(country: CountryType, lang: string) {
+  return {
+    selectedKey: `+${country.cdc}`,
+    selected_value: `${country.iso} (+${country.cdc})`,
+    content: `+${country.cdc} ${country.i18n[lang] ?? country.i18n.en}`,
+  }
+}
+
 PhoneNumber._supportsSpacingProps = true
 export default PhoneNumber
diff --git a/packages/dnb-eufemia/src/extensions/forms/Field/PhoneNumber/__tests__/PhoneNumber.test.tsx b/packages/dnb-eufemia/src/extensions/forms/Field/PhoneNumber/__tests__/PhoneNumber.test.tsx
@@ -83,13 +83,33 @@ describe('Field.PhoneNumber', () => {
     expect(onBlur).toHaveBeenLastCalledWith('+47 99999999')
   })
 
+  it('should have selected correct item', async () => {
+    render(<PhoneNumber />)
+
+    const codeElement: HTMLInputElement = document.querySelector(
+      '.dnb-forms-field-phone-number__country-code input'
+    )
+
+    expect(codeElement.value).toEqual('NO (+47)')
+
+    await userEvent.type(codeElement, ' ')
+
+    const items = document.querySelectorAll('li.dnb-drawer-list__option')
+    const item = Array.from(items).find((element) => {
+      return element.className.includes('selected')
+    })
+
+    expect(item.textContent).toBe('+47 Norge')
+  })
+
   it('should return correct value onChange event', async () => {
     const onChange = jest.fn()
     const onCountryCodeChange = jest.fn()
     render(
       <PhoneNumber
         onChange={onChange}
         onCountryCodeChange={onCountryCodeChange}
+        noAnimation
       />
     )
 
@@ -99,14 +119,31 @@ describe('Field.PhoneNumber', () => {
     await userEvent.type(phoneElement, '99999999')
     expect(onChange).toHaveBeenLastCalledWith('+47 99999999')
 
-    const codeElement = document.querySelector(
+    const codeElement: HTMLInputElement = document.querySelector(
       '.dnb-forms-field-phone-number__country-code input'
     )
 
+    expect(codeElement.value).toEqual('NO (+47)')
+
+    // open
+    fireEvent.keyDown(codeElement, {
+      key: 'ArrowDown',
+      keyCode: 40,
+    })
+
+    expect(
+      document.querySelectorAll('li.dnb-drawer-list__option')[0]
+        .textContent
+    ).toBe('+47 Norge')
+
+    fireEvent.focus(codeElement)
     fireEvent.change(codeElement, { target: { value: '+41' } })
     fireEvent.click(
       document.querySelectorAll('li.dnb-drawer-list__option')[0]
     )
+
+    expect(codeElement.value).toEqual('CH (+41)')
+
     await wait(1)
 
     expect(onCountryCodeChange).toHaveBeenCalledTimes(1)