Skip to content

Commit

Permalink
fix(StepIndicator): change chevron icon to pointing to the right (#1541)
Browse files Browse the repository at this point in the history
  • Loading branch information
@tujoworker
tujoworker authored Aug 31, 2022
1 parent ff1f3b7 commit 8529d8c
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 32 deletions.
4 changes: 2 additions & 2 deletions packages/dnb-eufemia/src/components/step-indicator/StepIndicatorTriggerButton.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import classnames from 'classnames'
import React from 'react'
import PropTypes from 'prop-types'
import Button from '../button/Button'
import chevron_down_medium from '../../icons/chevron_down_medium'
import chevron_icon from '../../icons/chevron_right_medium'
import {
validateDOMAttributes,
combineDescribedBy,
Expand Down Expand Up @@ -127,7 +127,7 @@ export default class StepIndicatorTriggerButton extends React.PureComponent {
wrap
stretch
variant="secondary"
icon={chevron_down_medium}
icon={chevron_icon}
icon_size="medium"
icon_position="right"
inner_ref={this._buttonRef}
Expand Down
60 changes: 30 additions & 30 deletions ...-eufemia/src/components/step-indicator/__tests__/__snapshots__/StepIndicator.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2226,7 +2226,7 @@ Array [
<span
aria-hidden="true"
class="dnb-icon dnb-icon--medium dnb-button__icon dnb-icon--inherit-color"
data-test-id="chevron down medium icon"
data-test-id="chevron right medium icon"
role="presentation"
>
<svg
Expand All @@ -2237,7 +2237,7 @@ Array [
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19 8.5-7 7-7-7"
d="m9 19 7-7-7-7"
stroke="#000"
stroke-linecap="round"
stroke-linejoin="round"
Expand Down Expand Up @@ -2343,7 +2343,7 @@ Array [
<span
aria-hidden="true"
class="dnb-icon dnb-icon--medium dnb-button__icon dnb-icon--inherit-color"
data-test-id="chevron down medium icon"
data-test-id="chevron right medium icon"
role="presentation"
>
<svg
Expand All @@ -2354,7 +2354,7 @@ Array [
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19 8.5-7 7-7-7"
d="m9 19 7-7-7-7"
stroke="#000"
stroke-linecap="round"
stroke-linejoin="round"
Expand Down Expand Up @@ -2457,7 +2457,7 @@ Array [
<span
aria-hidden="true"
class="dnb-icon dnb-icon--medium dnb-button__icon dnb-icon--inherit-color"
data-test-id="chevron down medium icon"
data-test-id="chevron right medium icon"
role="presentation"
>
<svg
Expand All @@ -2468,7 +2468,7 @@ Array [
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19 8.5-7 7-7-7"
d="m9 19 7-7-7-7"
stroke="#000"
stroke-linecap="round"
stroke-linejoin="round"
Expand Down Expand Up @@ -2555,10 +2555,10 @@ Array [
<span
aria-hidden={true}
className="dnb-icon dnb-icon--medium dnb-button__icon dnb-icon--inherit-color"
data-test-id="chevron down medium icon"
data-test-id="chevron right medium icon"
role="presentation"
>
<chevron_down_medium>
<chevron_right_medium>
<svg
fill="none"
height={24}
Expand All @@ -2567,14 +2567,14 @@ Array [
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19 8.5-7 7-7-7"
d="m9 19 7-7-7-7"
stroke="#000"
strokeLinecap="round"
strokeLinejoin="round"
strokeWidth={1.5}
/>
</svg>
</chevron_down_medium>
</chevron_right_medium>
</span>
</IconPrimary>
</Content>
Expand Down Expand Up @@ -4919,7 +4919,7 @@ Array [
<span
aria-hidden="true"
class="dnb-icon dnb-icon--medium dnb-button__icon dnb-icon--inherit-color"
data-test-id="chevron down medium icon"
data-test-id="chevron right medium icon"
role="presentation"
>
<svg
Expand All @@ -4930,7 +4930,7 @@ Array [
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19 8.5-7 7-7-7"
d="m9 19 7-7-7-7"
stroke="#000"
stroke-linecap="round"
stroke-linejoin="round"
Expand Down Expand Up @@ -5036,7 +5036,7 @@ Array [
<span
aria-hidden="true"
class="dnb-icon dnb-icon--medium dnb-button__icon dnb-icon--inherit-color"
data-test-id="chevron down medium icon"
data-test-id="chevron right medium icon"
role="presentation"
>
<svg
Expand All @@ -5047,7 +5047,7 @@ Array [
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19 8.5-7 7-7-7"
d="m9 19 7-7-7-7"
stroke="#000"
stroke-linecap="round"
stroke-linejoin="round"
Expand Down Expand Up @@ -5150,7 +5150,7 @@ Array [
<span
aria-hidden="true"
class="dnb-icon dnb-icon--medium dnb-button__icon dnb-icon--inherit-color"
data-test-id="chevron down medium icon"
data-test-id="chevron right medium icon"
role="presentation"
>
<svg
Expand All @@ -5161,7 +5161,7 @@ Array [
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19 8.5-7 7-7-7"
d="m9 19 7-7-7-7"
stroke="#000"
stroke-linecap="round"
stroke-linejoin="round"
Expand Down Expand Up @@ -5248,10 +5248,10 @@ Array [
<span
aria-hidden={true}
className="dnb-icon dnb-icon--medium dnb-button__icon dnb-icon--inherit-color"
data-test-id="chevron down medium icon"
data-test-id="chevron right medium icon"
role="presentation"
>
<chevron_down_medium>
<chevron_right_medium>
<svg
fill="none"
height={24}
Expand All @@ -5260,14 +5260,14 @@ Array [
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19 8.5-7 7-7-7"
d="m9 19 7-7-7-7"
stroke="#000"
strokeLinecap="round"
strokeLinejoin="round"
strokeWidth={1.5}
/>
</svg>
</chevron_down_medium>
</chevron_right_medium>
</span>
</IconPrimary>
</Content>
Expand Down Expand Up @@ -7626,7 +7626,7 @@ Array [
<span
aria-hidden="true"
class="dnb-icon dnb-icon--medium dnb-button__icon dnb-icon--inherit-color"
data-test-id="chevron down medium icon"
data-test-id="chevron right medium icon"
role="presentation"
>
<svg
Expand All @@ -7637,7 +7637,7 @@ Array [
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19 8.5-7 7-7-7"
d="m9 19 7-7-7-7"
stroke="#000"
stroke-linecap="round"
stroke-linejoin="round"
Expand Down Expand Up @@ -7743,7 +7743,7 @@ Array [
<span
aria-hidden="true"
class="dnb-icon dnb-icon--medium dnb-button__icon dnb-icon--inherit-color"
data-test-id="chevron down medium icon"
data-test-id="chevron right medium icon"
role="presentation"
>
<svg
Expand All @@ -7754,7 +7754,7 @@ Array [
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19 8.5-7 7-7-7"
d="m9 19 7-7-7-7"
stroke="#000"
stroke-linecap="round"
stroke-linejoin="round"
Expand Down Expand Up @@ -7857,7 +7857,7 @@ Array [
<span
aria-hidden="true"
class="dnb-icon dnb-icon--medium dnb-button__icon dnb-icon--inherit-color"
data-test-id="chevron down medium icon"
data-test-id="chevron right medium icon"
role="presentation"
>
<svg
Expand All @@ -7868,7 +7868,7 @@ Array [
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19 8.5-7 7-7-7"
d="m9 19 7-7-7-7"
stroke="#000"
stroke-linecap="round"
stroke-linejoin="round"
Expand Down Expand Up @@ -7955,10 +7955,10 @@ Array [
<span
aria-hidden={true}
className="dnb-icon dnb-icon--medium dnb-button__icon dnb-icon--inherit-color"
data-test-id="chevron down medium icon"
data-test-id="chevron right medium icon"
role="presentation"
>
<chevron_down_medium>
<chevron_right_medium>
<svg
fill="none"
height={24}
Expand All @@ -7967,14 +7967,14 @@ Array [
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19 8.5-7 7-7-7"
d="m9 19 7-7-7-7"
stroke="#000"
strokeLinecap="round"
strokeLinejoin="round"
strokeWidth={1.5}
/>
</svg>
</chevron_down_medium>
</chevron_right_medium>
</span>
</IconPrimary>
</Content>
Expand Down
Binary file modified ...ndicator-screenshot-have-to-match-loose-mode-for-small-screens-1-66f8b.snap.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...dicator-screenshot-have-to-match-strict-mode-for-small-screens-1-4e70f.snap.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 8529d8c

Please sign in to comment.