Skip to content

Commit

Permalink
fix(Modal): Safari Desktop fullscreen video issue (#1582)
Browse files Browse the repository at this point in the history
  • Loading branch information
tujoworker authored Sep 27, 2022
1 parent 8688b96 commit 5219ccd
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2272,7 +2272,7 @@ button.dnb-button::-moz-focus-inner {
.dnb-dialog__icon__primary.dnb-dialog__icon--info ::after {
background-color: var(--color-pistachio); }
html:not([data-visual-test]) .dnb-dialog {
animation: show-modal var(--modal-animation-duration) ease-out forwards; }
animation: show-modal var(--modal-animation-duration) ease-out; }
html:not([data-visual-test]) .dnb-dialog--hide {
animation: hide-modal 220ms ease-in-out forwards; }
.dnb-dialog--no-animation {
Expand Down Expand Up @@ -2367,7 +2367,7 @@ html[data-dnb-modal-active] {
.dnb-modal-root__inner .dnb-modal__overlay {
animation: hide-modal-overlay var(--modal-animation-duration) ease-out forwards; }
.dnb-modal-root__inner:last-of-type .dnb-modal__overlay {
animation: show-modal-overlay var(--modal-animation-duration) ease-out forwards; }
animation: show-modal-overlay var(--modal-animation-duration) ease-out; }
.dnb-modal-root__inner:last-of-type .dnb-modal__overlay--hide {
animation: hide-modal-overlay var(--modal-animation-duration) ease-out forwards; }
html[data-visual-test] .dnb-modal__overlay, .dnb-modal__overlay--no-animation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@

// Animation in
html:not([data-visual-test]) & {
animation: show-modal var(--modal-animation-duration) ease-out forwards;
animation: show-modal var(--modal-animation-duration) ease-out;
}
// Animation out
html:not([data-visual-test]) &--hide {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2287,7 +2287,7 @@ button.dnb-button::-moz-focus-inner {
.dnb-dialog__icon__primary.dnb-dialog__icon--info ::after {
background-color: var(--color-pistachio); }
html:not([data-visual-test]) .dnb-dialog {
animation: show-modal var(--modal-animation-duration) ease-out forwards; }
animation: show-modal var(--modal-animation-duration) ease-out; }
html:not([data-visual-test]) .dnb-dialog--hide {
animation: hide-modal 220ms ease-in-out forwards; }
.dnb-dialog--no-animation {
Expand Down Expand Up @@ -2382,7 +2382,7 @@ html[data-dnb-modal-active] {
.dnb-modal-root__inner .dnb-modal__overlay {
animation: hide-modal-overlay var(--modal-animation-duration) ease-out forwards; }
.dnb-modal-root__inner:last-of-type .dnb-modal__overlay {
animation: show-modal-overlay var(--modal-animation-duration) ease-out forwards; }
animation: show-modal-overlay var(--modal-animation-duration) ease-out; }
.dnb-modal-root__inner:last-of-type .dnb-modal__overlay--hide {
animation: hide-modal-overlay var(--modal-animation-duration) ease-out forwards; }
html[data-visual-test] .dnb-modal__overlay, .dnb-modal__overlay--no-animation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2259,7 +2259,7 @@ button.dnb-button::-moz-focus-inner {
.dnb-dialog__icon__primary.dnb-dialog__icon--info ::after {
background-color: var(--color-pistachio); }
html:not([data-visual-test]) .dnb-dialog {
animation: show-modal var(--modal-animation-duration) ease-out forwards; }
animation: show-modal var(--modal-animation-duration) ease-out; }
html:not([data-visual-test]) .dnb-dialog--hide {
animation: hide-modal 220ms ease-in-out forwards; }
.dnb-dialog--no-animation {
Expand Down Expand Up @@ -2354,7 +2354,7 @@ html[data-dnb-modal-active] {
.dnb-modal-root__inner .dnb-modal__overlay {
animation: hide-modal-overlay var(--modal-animation-duration) ease-out forwards; }
.dnb-modal-root__inner:last-of-type .dnb-modal__overlay {
animation: show-modal-overlay var(--modal-animation-duration) ease-out forwards; }
animation: show-modal-overlay var(--modal-animation-duration) ease-out; }
.dnb-modal-root__inner:last-of-type .dnb-modal__overlay--hide {
animation: hide-modal-overlay var(--modal-animation-duration) ease-out forwards; }
html[data-visual-test] .dnb-modal__overlay, .dnb-modal__overlay--no-animation {
Expand Down
3 changes: 1 addition & 2 deletions packages/dnb-eufemia/src/components/modal/style/_modal.scss
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ html[data-dnb-modal-active] {
}

&-root__inner:last-of-type &__overlay {
animation: show-modal-overlay var(--modal-animation-duration) ease-out
forwards;
animation: show-modal-overlay var(--modal-animation-duration) ease-out;

&--hide {
animation: hide-modal-overlay var(--modal-animation-duration)
Expand Down

0 comments on commit 5219ccd

Please sign in to comment.