chore(Tests): lint Jest tests (#3239)

dnbexperience · Jan 18, 2024 · 1fcb3f2 · 1fcb3f2
1 parent 6433470
commit 1fcb3f2
Show file tree

Hide file tree

Showing 86 changed files with 264 additions and 594 deletions.
diff --git a/packages/dnb-design-system-portal/.eslintignore b/packages/dnb-design-system-portal/.eslintignore
@@ -1,5 +1,4 @@
 !/*.js
-!/**/.eslintrc.js
 **/tests/**/*.js
 **/public/**
 **/static/**

diff --git a/packages/dnb-eufemia/.eslintignore b/packages/dnb-eufemia/.eslintignore
@@ -1,5 +1,4 @@
 !/*.js
-!/**/.eslintrc.js
 **/tests/**/*.js
 **/dist/**
 **/build/**

diff --git a/packages/dnb-eufemia/.eslintrc b/packages/dnb-eufemia/.eslintrc
@@ -26,6 +26,7 @@
     "plugin:security/recommended"
   ],
   "plugins": [
+    "jest",
     "import",
     "prettier",
     "react",
@@ -160,6 +161,11 @@
         "react/prop-types": "off",
         "react/require-default-props": "off"
       }
+    },
+    {
+      "files": ["**/__tests__/**"],
+      "plugins": ["jest"],
+      "extends": ["plugin:jest/recommended"]
     }
   ]
 }
diff --git a/packages/dnb-eufemia/.eslintrc.js b/packages/dnb-eufemia/.eslintrc.js
diff --git a/packages/dnb-eufemia/.npmignore b/packages/dnb-eufemia/.npmignore
@@ -28,7 +28,6 @@ README.md
 .storybook
 .eslintignore
 .eslintrc
-.eslintrc.json
 .flowconfig
 .prettierrc
 .releaserc*

diff --git a/packages/dnb-eufemia/package.json b/packages/dnb-eufemia/package.json
@@ -207,6 +207,7 @@
     "dotenv-cli": "4.1.0",
     "eslint": "8.17.0",
     "eslint-plugin-import": "2.26.0",
+    "eslint-plugin-jest": "27.6.3",
     "eslint-plugin-jsx-a11y": "6.5.1",
     "eslint-plugin-prettier": "5.0.0",
     "eslint-plugin-react": "7.30.0",

diff --git a/packages/dnb-eufemia/scripts/postbuild/__tests__/postbuild.test.ts b/packages/dnb-eufemia/scripts/postbuild/__tests__/postbuild.test.ts
@@ -1,3 +1,4 @@
+/* eslint-disable jest/no-conditional-expect */
 /**
  * Test for the post-build stage
  *

diff --git a/packages/dnb-eufemia/scripts/prebuild/tasks/__tests__/makeMainStyle.test.ts b/packages/dnb-eufemia/scripts/prebuild/tasks/__tests__/makeMainStyle.test.ts
@@ -31,7 +31,7 @@ if (isCI) {
       global.console.error = jest.fn()
       const css = loadScss(null, { data: global.core[0] })
       expect(/^Error/.test(css)).toBe(false)
-      expect(global.console.error).toBeCalled()
+      expect(global.console.error).toHaveBeenCalled()
     })
 
     it('has to have correct core path to fonts', () => {

diff --git a/...dnb-eufemia/scripts/prebuild/tasks/generateTypes/__tests__/babelPluginIncludeDocs.test.js b/...dnb-eufemia/scripts/prebuild/tasks/generateTypes/__tests__/babelPluginIncludeDocs.test.js
@@ -98,7 +98,7 @@ describe('babelPluginIncludeDocs', () => {
 
     expect(code).toMatchSnapshot()
 
-    expect(onComplete).toBeCalledTimes(1)
+    expect(onComplete).toHaveBeenCalledTimes(1)
     expect(collectProps).toMatchSnapshot()
   })
 })