handling of undefined, as @navikt/fnrvalidator does not support it

dnbexperience · Oct 8, 2024 · 1ac5556 · 1ac5556
1 parent 2892d92
commit 1ac5556
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.../dnb-eufemia/src/extensions/forms/Field/NationalIdentityNumber/NationalIdentityNumber.tsx b/.../dnb-eufemia/src/extensions/forms/Field/NationalIdentityNumber/NationalIdentityNumber.tsx
@@ -46,7 +46,8 @@ function NationalIdentityNumber(props: Props) {
 
   const fnrValidator = useCallback(
     (value: string) => {
-      if (fnr(value).status === 'invalid') {
+      // have to check for undefined as @navikt/fnrvalidator does not support undefined
+      if (value === undefined || fnr(value).status === 'invalid') {
         return Error(errorFnr)
       }
     },
@@ -55,7 +56,8 @@ function NationalIdentityNumber(props: Props) {
 
   const dnrValidator = useCallback(
     (value: string) => {
-      if (dnr(value).status === 'invalid') {
+      // have to check for undefined as @navikt/fnrvalidator does not support undefined
+      if (value === undefined || dnr(value).status === 'invalid') {
         return Error(errorDnr)
       }
     },

diff --git a/...c/extensions/forms/Field/NationalIdentityNumber/__tests__/NationalIdentityNumber.test.tsx b/...c/extensions/forms/Field/NationalIdentityNumber/__tests__/NationalIdentityNumber.test.tsx
@@ -63,7 +63,10 @@ describe('Field.NationalIdentityNumber', () => {
     rerender(<Field.NationalIdentityNumber validateInitially />)
 
     await waitFor(() => {
-      expect(screen.queryByRole('alert')).not.toBeInTheDocument()
+      expect(screen.queryByRole('alert')).toBeInTheDocument()
+      expect(screen.queryByRole('alert')).toHaveTextContent(
+        nb.NationalIdentityNumber.errorFnr
+      )
     })
   })