Skip to content

Commit

Permalink
fix(GlobalStatus): remove z-index to enhance flexibility (#2952)
Browse files Browse the repository at this point in the history
The z-index usage was introduces in [this
commit](1fb638b#diff-4d582f82c1661d8de20042e6e65250a4d2710c2b31f8955fcd6eda14097a0b4e)
in 2019 (v4).

Today, I can't find any good reasons why to have it anymore. Surely, it
"could" break something visually. But I think we still are pretty safe
going forward without a z-index.

More info in this [Slack
thread](https://dnb-it.slack.com/archives/CMXABCHEY/p1700653977331569).
  • Loading branch information
tujoworker authored Dec 1, 2023
1 parent b522bd7 commit 13a9d6e
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { GlobalStatusExampleControllers } from 'Docs/uilib/components/global-sta
| `text` or `children` | _(optional)_ the text appears as the status content. Besides plain text, you can send in a React component as well. Defaults to `null`. |
| `items` | _(optional)_ the items (list items) appear as a part of the status content. you can both use an JSON array, or a vanilla array with a string or an object content. See **Item Object** example below. |
| `icon` | _(optional)_ the icon shown before the status title. Defaults to `exclamation`. |
| `state` | _(optional)_ defines the visual appearance of the status. There are two main statuses `error` and `info`. The default status is `error`. |
| `state` | _(optional)_ defines the visual appearance of the status. There are two main statuses `error`, `warning`, `info` and `success`. The default status is `error`. |
| `icon_size` | _(optional)_ the icon size of the title icon shows. Defaults to `medium`. |
| `show` | _(optional)_ set to `true` or `false` to manually make the global status visible. Defaults to `true`. |
| `autoclose` | _(optional)_ set to `true` to automatically close the global status if there are no more left items in the provider stack. Defaults to `true`. |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -710,10 +710,6 @@ button.dnb-button::-moz-focus-inner {
.dnb-global-status.dnb-section {
display: block;
}
.dnb-global-status__wrapper {
position: relative;
z-index: 1;
}
.dnb-global-status__shell {
width: 100%;
opacity: 1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@
display: block;
}

&__wrapper {
position: relative;
z-index: 1;
}

&__shell {
width: 100%;
opacity: 1;
Expand Down

0 comments on commit 13a9d6e

Please sign in to comment.