Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to matcher to ignore authorization header #103

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

zhammer
Copy link
Contributor

@zhammer zhammer commented Sep 9, 2024

The suggestion in the readme to clear authorization headers in hooks isn't working for us; when we attempt to run against the recorded cassettes the match fails as the http.Request has an Authorization header that the cassette interaction doesn't.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.40%. Comparing base (1ae1a38) to head (23299c2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               v4     #103      +/-   ##
==========================================
+ Coverage   51.61%   52.40%   +0.79%     
==========================================
  Files           4        4              
  Lines         494      498       +4     
==========================================
+ Hits          255      261       +6     
+ Misses        218      217       -1     
+ Partials       21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dnaeon dnaeon merged commit d91ca23 into dnaeon:v4 Sep 10, 2024
2 checks passed
@dnaeon
Copy link
Owner

dnaeon commented Sep 10, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants