DEP PHP Support in CMS5 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sabina-talipova
force-pushed
the
pulls/4/upgrade-cms5
branch
from
009ec5b to
e580bbf
Compare
|
silverstripe/silverstripe-userforms#1182 should be merged first |
sabina-talipova
force-pushed
the
pulls/4/upgrade-cms5
branch
2 times, most recently
from
084f482 to
c931ee3
Compare
maxime-rainville
requested changes
Jan 12, 2023
composer.json
Outdated
| "silverstripe/vendor-plugin": "^1.0" | ||
| "php": "^8.1", | ||
| "silverstripe/framework": "^5", | ||
| "dnadesign/silverstripe-elemental": "5.0.0-alpha2", |
There was a problem hiding this comment.
Suggested change
| "dnadesign/silverstripe-elemental": "5.0.0-alpha2", | |
| "dnadesign/silverstripe-elemental": "^5.0.0-alpha2", |
There was a problem hiding this comment.
That will allow the installation of later 5.x version.
sabina-talipova
force-pushed
the
pulls/4/upgrade-cms5
branch
from
c931ee3 to
98ebc6f
Compare
|
Broken Behat tests are related to the issue https://github.com/silverstripeltd/product-issues/issues/655 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue