-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix duplicated DQM sequences for MinimumBias
PDs
#4625
Conversation
…cepted the Strip DQM
Can one of the admins verify this patch? |
I totally agree, also to be in sync with ZeroBias definition. |
Thanks for noticing @mmusich. I'm guessing, since these sequences have been there for a while, that this is not an urgent change. Would it be ok to keep these changes until the next testing cycle or is it important to have in production for Pilot Beam? |
@germanfgv There's no urgency. I made the PR just to avoid forgetting. |
coming back to this after the beam test, kindly pinging @germanfgv |
Thanks for the reminder, I'll start the replay |
run replay please |
Replay testing PR 'fix duplicated DQM sequences for |
@mmusich the replay finished without issues. We can make this changes in the next production configuration update. |
Merged to master in #4634. This PR can me closed. |
Casually looking at the T0 configuration I noticed that e.g.:
while
@common
and@commonSiStripZeroBias
have many sequences in common, excepted the Pixel, Strip and Tracking DQM sequences.https://github.com/cms-sw/cmssw/blob/027525058713f5a07c90d0530bb8c4a7448d3306/DQMOffline/Configuration/python/autoDQM.py#L9-L11
vs
https://github.com/cms-sw/cmssw/blob/027525058713f5a07c90d0530bb8c4a7448d3306/DQMOffline/Configuration/python/autoDQM.py#L17-L19
I think only
@commonSiStripZeroBias
is the one to keep.@jfernan2 @tvami