Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checkS3Object and verify S3 upload with it #8740

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

belforte
Copy link
Member

No description provided.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 46 comments to review
  • Pycodestyle check: succeeded
    • 85 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2198/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: succeeded
    • 34 comments to review
  • Pycodestyle check: succeeded
    • 85 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2199/artifact/artifacts/PullRequestReport.html

@novicecpp
Copy link
Contributor

🚀 🚀 🚀

@belforte
Copy link
Member Author

I had only tested from client. But uploading of twlog now fails with

 'x-error-info': 'taskname is missing'
2024-10-17 11:46:45,900:DEBUG:ServerUtilities:upload to S3 of twlog ./logs/tasks/crabint1/241017_084637:crabint1_crab_20241017_104637.log completed
2024-10-17 11:46:45,900:DEBUG:ServerUtilities:make sure that object is ready for retrieve
2024-10-17 11:46:46,943:ERROR:RESTInteractions:Rejected request when connecting to https://cmsweb-test2.cern.ch:8443/crabserver/dev/cache using subresource=download&objecttype=twlog&clientmethod=head_object. Error details: {'content-type': 'text/html;charset=utf-8', 'date': 'Thu, 17 Oct 2024 09:46:46 GMT', 'response-proto': 'HTTP/1.1', 'response-status': '400 Bad Request', 'response-status-code': '400', 'response-time': '15.413685ms', 'response-time-seconds': '0.015414353', 'server': 'CherryPy/18.8.0', 'x-content-type-options': 'bla', 'x-error-detail': 'Missing required parameter', 'x-error-http': '400', 'x-error-id': '4e6d3d37d4501074f907d5e1956b71e1', 'x-error-info': 'taskname is missing', 'x-rest-status': '301', 'x-rest-time': '9303.570 us', 'content-length': '736'}

@belforte belforte added the PR: do not merge This PR is a work in progress and not ready to be merged label Oct 17, 2024
@novicecpp
Copy link
Contributor

Ah yes. It is used for S3 path construction.

  • All sandbox are put together inside <username>/sandboxes/ => to share across tasks
  • and for twlog it use <username>/<taskname>/twlog. => individual task.

@belforte
Copy link
Member Author

thanks Wa. No worry. It was my code, I will figure out. I have doing more than one thing at same time atm. gimme a bit to get to this

@belforte
Copy link
Member Author

fixed

@belforte belforte removed the PR: do not merge This PR is a work in progress and not ready to be merged label Oct 17, 2024
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: succeeded
    • 34 comments to review
  • Pycodestyle check: succeeded
    • 85 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2210/artifact/artifacts/PullRequestReport.html

@belforte
Copy link
Member Author

belforte commented Oct 17, 2024

@belforte belforte merged commit 256760a into dmwm:master Oct 18, 2024
2 checks passed
@belforte belforte deleted the add-checkS3Object branch October 18, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants