Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abort dag_bootstrap if task already runs (fix #6151) #6320

Merged
merged 2 commits into from
Jan 6, 2021
Merged

abort dag_bootstrap if task already runs (fix #6151) #6320

merged 2 commits into from
Jan 6, 2021

Conversation

ddaina
Copy link
Contributor

@ddaina ddaina commented Jan 6, 2021

using crab-preprod-tw02 and vocms059 I tested following cases:

  1. AdjustSites.py tries to run when task is not submitted
  2. AdjustSites.py tries to run when task is submitted but clusterId on DB is different compared to what is condor ads
  3. AdjustSites.py tries to run when task is submitted but schedd on DB is equal toNone

in all above cases script terminates

@ddaina ddaina requested a review from belforte January 6, 2021 16:10
@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: succeeded
  • Pylint check: succeeded
    • 1 warnings
    • 11 comments to review
  • Pycodestyle check: succeeded
    • 1 comments to review
  • Python3 compatibility checks: failed
    • fails python3 compatibility test

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/634/artifact/artifacts/PullRequestReport.html

belforte
belforte requested changes Jan 6, 2021
View reviewed changes
Copy link
Member

@belforte belforte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Please change 'scheddy' to 'schedd' and adjust the message when startup is aborted as in my comment.

@belforte
Copy link
Member

belforte commented Jan 6, 2021

perfect

@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: succeeded
  • Pylint check: succeeded
    • 1 warnings
    • 11 comments to review
  • Pycodestyle check: succeeded
    • 1 comments to review
  • Python3 compatibility checks: failed
    • fails python3 compatibility test

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/635/artifact/artifacts/PullRequestReport.html

@ddaina ddaina merged commit e493458 into dmwm:master Jan 6, 2021
@ddaina ddaina deleted the fix_#6151 branch January 6, 2021 21:18
@belforte belforte mentioned this pull request Jan 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belforte belforte belforte requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddaina @cmsdmwmbot @belforte