Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use WMCore.Configuration (fix #5119) #5120

Merged
merged 1 commit into from
Nov 25, 2021
Merged

use WMCore.Configuration (fix #5119) #5120

merged 1 commit into from
Nov 25, 2021

Conversation

ddaina
Copy link
Contributor

@ddaina ddaina commented Nov 25, 2021

No description provided.

@ddaina ddaina requested a review from belforte November 25, 2021 16:42
@ddaina ddaina merged commit b033ff0 into dmwm:master Nov 25, 2021
@mapellidario
Copy link
Member

The module https://github.com/dmwm/CRABClient/blob/master/src/python/CRABClient/WMCoreConfigWrapper.py has not been changed. Are we still using it? Should we remove it? Or should we change the import in there, too?

@ddaina
Copy link
Contributor Author

ddaina commented Nov 26, 2021

@belforte
Copy link
Member

We will revisit this as "cleanup" once dust settles on the python3 migration and we review the situation.
Given enough time it is conceivable to go back to "stop importing from WMCore", e.g. we should start by not putting the config in the .requestcache pickle file, wait one months for all task around to have the new files and go on.
Or we find a way to make both fromWMcore and fromCRABClient work at same time and rather move the warning from the wrapper into the WMCore/Configution.py ...

So let's keep this file around for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants