New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add launch queue and launch params section #1

Merged

evanstade merged 5 commits into dmurph:file-handling from loubrett:file-handling

Mar 2, 2022

loubrett commented Feb 17, 2022

No description provided.

loubrett added 2 commits

February 17, 2022 15:28


          Add section for launch queue and launch params

f64fc16


          Add section for launch queue and launch params

f7b32e9

loubrett marked this pull request as ready for review

February 17, 2022 06:17

Author

loubrett commented Feb 17, 2022

PTAL @evanstade.
I haven't changed any of what you had written already so there's now a bit of overlap that will need to be removed. Let me know if you'd like me to try fixing that up.
I'm also unsure how to get a preview showing so there is likely some formatting errors.

evanstade reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

evanstade reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

evanstade reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

evanstade reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

evanstade reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

evanstade reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

evanstade reviewed

View reviewed changes

Collaborator

evanstade left a comment

Thanks for the changes!

You can preview by simply opening index.html in a browser.


          Address comments

4903da0

Author

loubrett commented Mar 1, 2022

Thanks for the comments! PTAL

loubrett requested a review from evanstade

March 1, 2022 02:13

evanstade reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

evanstade reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

evanstade reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

evanstade reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

alancutter reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated

+                        Handling Web App Launches
+                      </h3>
+                      <p>
+                        The steps to <dfn>launch a web app</dfn> are given by the

alancutter Mar 2, 2022

The "launch a web app" process is unused. The "Execute a file handler launch" process should call into to this algorithm with its custom LaunchParams.

Author

loubrett Mar 2, 2022

Evan has a PR (#2) which does that.

index.html Outdated Show resolved Hide resolved


          Comments

d1916e2

alancutter approved these changes

View reviewed changes

alancutter left a comment

Awesome, thanks!


          Update index.html

603b58f

Collaborator

evanstade commented Mar 2, 2022

There are validation issues because prs #1 and #2 depend on each other. I'll just go ahead and merge this one then address them in my PR.

evanstade merged commit dea41ae into dmurph:file-handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet