Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: delay option in realSwipe #620

Closed
alirezamirian opened this issue Jan 29, 2024 · 3 comments · Fixed by #621 or Cognigy/Webchat#26
Closed

feature request: delay option in realSwipe #620

alirezamirian opened this issue Jan 29, 2024 · 3 comments · Fixed by #621 or Cognigy/Webchat#26
Labels
released

Comments

@alirezamirian
Copy link
Contributor

alirezamirian commented Jan 29, 2024 •
edited
Loading

Some UI components that support drag/swipe by touch, ignore immediate touch move after touch start, not to interfere with page scrolling. Example: https://react-spectrum.adobe.com/react-spectrum/RangeCalendar.html

Right now it's not possible to use realSwipe for testing such components. There is also no support for lower-level commands like touchStart and touchEnd to implement such touch gestures.

Adding an option to specify the delay between touch start and touch moves would help covering such scenarios.
I've already tested it and I can open a PR if the option makes sense.

Alternative solutions

  1. Expose lower-level commands, realTouchStart, realTouchMove and realTouchEnd (similar to realMouseDown, realMouseMove, and realMouseUp)
  2. Add a different command, like realDrag, that would have a similar delay option, and an option to specify if the drag is via touch or mouse.
@dmtrKovalenko
Copy link
Owner

Both options seems to be relevant. PRs are welcome

alirezamirian added a commit to alirezamirian/cypress-real-events that referenced this issue Jan 30, 2024
@alirezamirian
feat(realSwipe): add touchMoveDelay option
0058142 
closes dmtrKovalenko#620
@alirezamirian alirezamirian mentioned this issue Jan 30, 2024
Merged
alirezamirian added a commit to alirezamirian/cypress-real-events that referenced this issue Jan 30, 2024
@alirezamirian
feat(realSwipe): add touchMoveDelay option
86b2240 
closes dmtrKovalenko#620
alirezamirian added a commit to alirezamirian/cypress-real-events that referenced this issue Jan 30, 2024
@alirezamirian
feat(realSwipe): add touchMoveDelay option
afb0254 
closes dmtrKovalenko#620
dmtrKovalenko pushed a commit to alirezamirian/cypress-real-events that referenced this issue Feb 16, 2024
@alirezamirian @dmtrKovalenko
feat(realSwipe): add touchMoveDelay option
49dda19 
closes dmtrKovalenko#620
dmtrKovalenko pushed a commit that referenced this issue Feb 16, 2024
@alirezamirian
feat: add touchMoveDelay option to realSwipe (#621)
50f46f2 
* chore(docs): fix a few typos and issues in realSwipe docs

* feat(realSwipe): add `touchMoveDelay` option

closes #620
dmtrKovalenko pushed a commit that referenced this issue Feb 16, 2024
@alirezamirian @dmtrKovalenko
feat: add touchMoveDelay option to realSwipe (#621)
4786db2 
* chore(docs): fix a few typos and issues in realSwipe docs

* feat(realSwipe): add `touchMoveDelay` option

closes #620
@dmtrKovalenko
Copy link
Owner

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

dmtrKovalenko added a commit that referenced this issue Jun 15, 2024
@amoshydra @dmtrKovalenko
@dependabot @RahulRaj97 @alirezamirian @nicklemmon
fix: default x y to 0 when not provided, accept 0 value (#642)
beb4749 
* chore(deps-dev): bump eslint-plugin-cypress from 2.14.0 to 2.15.1

Bumps [eslint-plugin-cypress](https://github.com/cypress-io/eslint-plugin-cypress) from 2.14.0 to 2.15.1.
- [Release notes](https://github.com/cypress-io/eslint-plugin-cypress/releases)
- [Commits](cypress-io/eslint-plugin-cypress@v2.14.0...v2.15.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-cypress
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps-dev): bump fs-extra from 11.1.1 to 11.2.0

Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra) from 11.1.1 to 11.2.0.
- [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md)
- [Commits](jprichardson/node-fs-extra@11.1.1...11.2.0)

---
updated-dependencies:
- dependency-name: fs-extra
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: Trying to resolve issue with 404 on chrome driver installation (#633)

* docs: Update links and comments for realSwipe function (#630)

Co-authored-by: Rahul Raj <[email protected]>

* feat: add touchMoveDelay option to realSwipe (#621)

* chore(docs): fix a few typos and issues in realSwipe docs

* feat(realSwipe): add `touchMoveDelay` option

closes #620

* fix:  and  interfaces are consistently cased with other option interfaces (#612)

* chore(closes #243): Add README to the npm release tarball

* chore(deps-dev): bump typedoc from 0.24.8 to 0.25.8 (#629)

Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.24.8 to 0.25.8.
- [Release notes](https://github.com/TypeStrong/TypeDoc/releases)
- [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md)
- [Commits](TypeStrong/typedoc@v0.24.8...v0.25.8)

---
updated-dependencies:
- dependency-name: typedoc
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump eslint from 8.48.0 to 8.56.0 (#605)

Bumps [eslint](https://github.com/eslint/eslint) from 8.48.0 to 8.56.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.48.0...v8.56.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump typedoc-plugin-markdown from 3.15.3 to 3.17.1 (#587)

Bumps [typedoc-plugin-markdown](https://github.com/tgreyuk/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) from 3.15.3 to 3.17.1.
- [Release notes](https://github.com/tgreyuk/typedoc-plugin-markdown/releases)
- [Changelog](https://github.com/tgreyuk/typedoc-plugin-markdown/blob/master/packages/typedoc-plugin-markdown/CHANGELOG.md)
- [Commits](https://github.com/tgreyuk/typedoc-plugin-markdown/commits/[email protected]/packages/typedoc-plugin-markdown)

---
updated-dependencies:
- dependency-name: typedoc-plugin-markdown
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: default x y to 0 when not provided, accept 0 value

* chore(ci): fix chrome driver issue

* chore(jsdoc): Fix the link to the real swipe docs (#634)

Co-authored-by: stevenlee <[email protected]>

* fix: default x y to 0 when not provided, accept 0 value

* chore(deps-dev): bump fs-extra from 11.1.1 to 11.2.0

Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra) from 11.1.1 to 11.2.0.
- [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md)
- [Commits](jprichardson/node-fs-extra@11.1.1...11.2.0)

---
updated-dependencies:
- dependency-name: fs-extra
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps-dev): bump eslint from 8.48.0 to 8.56.0 (#605)

Bumps [eslint](https://github.com/eslint/eslint) from 8.48.0 to 8.56.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.48.0...v8.56.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump typedoc-plugin-markdown from 3.15.3 to 3.17.1 (#587)

Bumps [typedoc-plugin-markdown](https://github.com/tgreyuk/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) from 3.15.3 to 3.17.1.
- [Release notes](https://github.com/tgreyuk/typedoc-plugin-markdown/releases)
- [Changelog](https://github.com/tgreyuk/typedoc-plugin-markdown/blob/master/packages/typedoc-plugin-markdown/CHANGELOG.md)
- [Commits](https://github.com/tgreyuk/typedoc-plugin-markdown/commits/[email protected]/packages/typedoc-plugin-markdown)

---
updated-dependencies:
- dependency-name: typedoc-plugin-markdown
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(jsdoc): Fix the link to the real swipe docs (#634)

Co-authored-by: stevenlee <[email protected]>

* fix: default x y to 0 when not provided, accept 0 value

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Dmitriy Kovalenko <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rahul Raj <[email protected]>
Co-authored-by: Rahul Raj <[email protected]>
Co-authored-by: Alireza Mirian <[email protected]>
Co-authored-by: Nick Lemmon <[email protected]>
Co-authored-by: stevenlee <[email protected]>
@dmtrKovalenko
Copy link
Owner

🎉 This issue has been resolved in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lkolapp lkolapp mentioned this issue Sep 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@alirezamirian @dmtrKovalenko