-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculation of coordinates are wrong when Cypress scales the application view port #317
Comments
Im-a-Train
added a commit
to Im-a-Train/cypress-real-events
that referenced
this issue
Nov 8, 2022
…e viewport is scaled dmtrKovalenko#317
Thank you for digging into this— we are also having this issue! |
dmtrKovalenko
pushed a commit
that referenced
this issue
Nov 10, 2022
… scaled (#323) * fix: use the cypress viewport scale to prevent a position shift if the viewport is scaled #317 * no scaling on the click radius * fixed right click test * added tests for viewport scaling with a custom drawCanvas * fix small code smells in the drawCanvas test page * merged dependency updates in develop from main repo * fixed error with internal registries in yarn.lock * fix out folder for compareImage diffs to screenshots * fix max allowed pixel difference
Thanks all! New release is working like a charm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Depending on the Cypress view port scaling, the coordinates are calculated different and with the wrong proportions.
Code to reproduce:
Current Behavior:
The same test code produces different output, depending on the view port scaling:
View Port 100%:
View Port 56%:
realEventsWrongCoordinates.mp4
Expected Behavior
The view port scaling should not affect the test output.
Versions
The text was updated successfully, but these errors were encountered: