chore(refactor): grab frameElement using slightly stricter logic (#37)

src/getCypressElementCoordinates.ts

@@ -67,6 +67,22 @@ function scrollIntoView(
   htmlElement.scrollIntoView({ block });
 }
 
+// for cross origin domains .frameElement returns null so query using parentWindow
+// but when running using --disable-web-security it will return the frame element
+function getFrameElement(currentWindow: Window): HTMLElement {
+  if (currentWindow.frameElement) {
+    // accessible for same-origin iframes
+    // or when running with --disable-web-security
+    return currentWindow.frameElement as HTMLElement;
+  }
+
+  // fallback to querying using the parent window, mainly to grab the AUT iframe
+  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+  return [...currentWindow.parent.document.querySelectorAll("iframe")].find(
+    (iframe) => iframe.contentWindow === currentWindow
+  )!;
+}
+
 function getIframesPositionShift(element: HTMLElement) {
   let currentWindow: Window | null = element.ownerDocument.defaultView;
   const noPositionShift = {
@@ -80,26 +96,17 @@ function getIframesPositionShift(element: HTMLElement) {
   }
 
   // eslint-disable-next-line prefer-const
-  const iframes = []
-
-  while (
-    currentWindow &&
-    currentWindow !== window.top
-  ) {
-    iframes.push(
-      // for cross origin domains .frameElement returns null so query using parentWindow
-      // but when running using --disable-web-security it will return the frame element
-      (currentWindow.frameElement as HTMLElement) ??
-        currentWindow.parent.document.querySelector("iframe")
-    );
+  const iframes = [];
 
+  while (currentWindow !== window.top) {
+    iframes.push(getFrameElement(currentWindow));
     currentWindow = currentWindow.parent;
   }
 
-  return iframes.reduceRight(({ frameX, frameY, frameScale }, frame) => { 
+  return iframes.reduceRight(({ frameX, frameY, frameScale }, frame) => {
     const { x, y, width } = frame.getBoundingClientRect();
 
-    return { 
+    return {
       frameX: frameX + x * frameScale,
       frameY: frameY + y * frameScale,
       frameScale: frameScale * (width / frame.offsetWidth),

tsconfig.json

@@ -3,7 +3,7 @@
     "types": ["cypress"],
     "target": "es6",
     "module": "commonjs",
-    "lib": ["DOM","ES2016"],
+    "lib": ["DOM", "DOM.Iterable", "ES2016"],
     "outDir": "dist",
     "declaration": true,
     "strict": true,