Always use partition based categorical splits. #7857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RAMitchell
reviewed
May 2, 2022
src/common/categorical.h
Outdated
| @@ -83,7 +83,7 @@ inline void InvalidCategory() { | |||
| * \brief Whether should we use onehot encoding for categorical data. | |||
| */ | |||
| XGBOOST_DEVICE inline bool UseOneHot(uint32_t n_cats, uint32_t max_cat_to_onehot, ObjInfo task) { | |||
There was a problem hiding this comment.
Remove task argument. I think with this change task can be removed from a lot of function arguments.
There was a problem hiding this comment.
Thank you for reminding me of that. All removed.
RAMitchell
approved these changes
May 3, 2022
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
May 6, 2022
trivialfis
added a commit
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My mistake, we are always using regression trees.