-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support XGBoost UBJSON #578
Conversation
@trivialfis FYI, I managed to implement the UBJSON support without too much work. It reuses the event-based parser we use for parsing XGBoost JSON models. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mainline #578 +/- ##
============================================
- Coverage 84.92% 84.77% -0.16%
============================================
Files 71 75 +4
Lines 6347 6547 +200
Branches 521 528 +7
============================================
+ Hits 5390 5550 +160
- Misses 957 997 +40 ☔ View full report in Codecov by Sentry. |
Cool, the nlohmann JSON is excellent, glad that it can be directly used here. |
Treelite 4.3.0 contains the following improvements: * Support XGBoost 2.1.0, including the UBJSON format (dmlc/treelite#572, dmlc/treelite#578) * [GTIL] Allow inferencing with FP32 input + FP64 model (dmlc/treelite#574). Related: triton-inference-server/fil_backend#391 * Prevent integer overflow for deep LightGBM trees by using DFS order (dmlc/treelite#570). * Support building with latest RapidJSON (dmlc/treelite#567) Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - James Lamb (https://github.com/jameslamb) - Dante Gama Dessavre (https://github.com/dantegd) URL: #5968
Closes #573
Use https://github.com/nlohmann/json to parse UBJSON as it has the following advantages: