[Breaking] Set 1st dim of prediction output to be row ID #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## mainline #549 +/- ##
============================================
- Coverage 84.33% 84.29% -0.04%
============================================
Files 71 71
Lines 6069 6068 -1
Branches 510 510
============================================
- Hits 5118 5115 -3
- Misses 951 953 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing tree prediction in parallel, it is common to split the workload over the data row dimension. So it would be beneficial to put the row ID as the first (outer-most) dimension. In addition, both XGBoost and scikit-learn RandomForestRegressor puts the row ID in the first dimension when predicting with multi-target models.