Restore support for old binary XGBoost models #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mainline #547 +/- ##
============================================
+ Coverage 84.25% 84.35% +0.10%
============================================
Files 70 70
Lines 6064 6066 +2
Branches 510 510
============================================
+ Hits 5109 5117 +8
+ Misses 955 949 -6 ☔ View full report in Codecov by Sentry. |
hcho3
force-pushed
the
fix_xgb_old_model
branch
from
f18698f
to
bcdf694
Compare
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Apr 1, 2024
Treelite 4.1.2 contains important bug fixes such as: * dmlc/treelite#547 * dmlc/treelite#552 * dmlc/treelite#553 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Ray Douglass (https://github.com/raydouglass) URL: #5814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XGBoost models from 2 years ago (1.5 or older) won't have
num_targetfield in the model. The model parser shouldn't fail ifnum_targetis 0.