Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate C codegen #493

Merged
merged 2 commits into from
May 5, 2023
Merged

Deprecate C codegen #493

merged 2 commits into from
May 5, 2023

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented May 5, 2023

Deprecate C codegen part of Treelite. Direct users to use TL2cgen instead.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.88 ⚠️

Comparison is base (4c48e16) 85.34% compared to head (af7074b) 84.47%.

❗ Current head af7074b differs from pull request most recent head b8b053e. Consider uploading reports for the commit b8b053e to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             mainline     #493      +/-   ##
==============================================
- Coverage       85.34%   84.47%   -0.88%     
  Complexity         42       42              
==============================================
  Files             112      113       +1     
  Lines            9910     8868    -1042     
  Branches          617       40     -577     
==============================================
- Hits             8458     7491     -967     
+ Misses           1429     1354      -75     
  Partials           23       23              
Impacted Files Coverage Δ
python/treelite/annotator.py 84.37% <100.00%> (+1.04%) ⬆️
python/treelite/contrib/__init__.py 69.84% <100.00%> (-5.57%) ⬇️
python/treelite/frontend.py 78.12% <100.00%> (+0.23%) ⬆️
python/treelite/warn.py 100.00% <100.00%> (ø)
runtime/python/treelite_runtime/predictor.py 86.52% <100.00%> (-0.32%) ⬇️
runtime/python/treelite_runtime/warn.py 100.00% <100.00%> (ø)

... and 66 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hcho3 hcho3 merged commit aa45b20 into dmlc:mainline May 5, 2023
@hcho3 hcho3 deleted the deprecate_codegen branch May 5, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant