Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Build and package Treelite with OpenMP #353

Merged
merged 18 commits into from
Feb 3, 2022
Merged

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Feb 2, 2022

  • Rewrite ParallelFor using OpenMP constructs.
  • Link Treelite libs with OpenMP runtime lib.
  • On MacOS, bundle libomp (OpenMP runtime) with Treelite. This is to ensure that Treelite does not randomly crash. [CI] Build Python wheels for MacOS (x86_64 and arm64) xgboost#7621 for full explanation.
  • Build PyPI wheel targeting Apple Silicon. Closes Apple Silicon support #350
  • On Linux, run auditwheel repair command to vendor (bundle) libgomp.so inside the Python wheel. This is required by the Python packaging standard.

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #353 (5bb230b) into mainline (ab699e7) will decrease coverage by 0.36%.
The diff coverage is 62.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #353      +/-   ##
==============================================
- Coverage       85.01%   84.65%   -0.37%     
  Complexity         44       44              
==============================================
  Files             108      109       +1     
  Lines            8461     8457       -4     
  Branches          480      474       -6     
==============================================
- Hits             7193     7159      -34     
- Misses           1244     1274      +30     
  Partials           24       24              
Impacted Files Coverage Δ
src/threading_utils/parallel_for.h 55.55% <53.44%> (-44.45%) ⬇️
tests/cpp/test_threading_utils.cc 94.11% <90.00%> (-2.23%) ⬇️
src/annotator.cc 91.17% <100.00%> (+0.10%) ⬆️
include/treelite/omp.h 50.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab699e7...5bb230b. Read the comment docs.

@hcho3 hcho3 marked this pull request as ready for review February 3, 2022 06:56
@hcho3 hcho3 changed the title Add back OpenMP [CI] Build and package Treelite with OpenMP Feb 3, 2022
@hcho3 hcho3 merged commit f815a58 into dmlc:mainline Feb 3, 2022
@hcho3 hcho3 deleted the add_openmp branch February 3, 2022 07:57
This was referenced Feb 17, 2022
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Feb 22, 2022
The 2.3.0 version of Treelite incorporates the following improvements:
* GTIL optimization using multiple CPU threads (dmlc/treelite#353, dmlc/treelite#355, dmlc/treelite#357, dmlc/treelite#358, dmlc/treelite#362, dmlc/treelite#367)
* dmlc/treelite#365
* dmlc/treelite#366
* dmlc/treelite#368

Requires rapidsai/integration#436

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #4590
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
The 2.3.0 version of Treelite incorporates the following improvements:
* GTIL optimization using multiple CPU threads (dmlc/treelite#353, dmlc/treelite#355, dmlc/treelite#357, dmlc/treelite#358, dmlc/treelite#362, dmlc/treelite#367)
* dmlc/treelite#365
* dmlc/treelite#366
* dmlc/treelite#368

Requires rapidsai/integration#436

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#4590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple Silicon support
1 participant