Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treelite fails to load sklearn RF multi-output regression model #375

Closed
RAMitchell opened this issue Mar 25, 2022 · 1 comment
Closed

Treelite fails to load sklearn RF multi-output regression model #375

RAMitchell opened this issue Mar 25, 2022 · 1 comment

Comments

@RAMitchell
Copy link
Member

Reproducer:

import treelite
from sklearn.ensemble import RandomForestRegressor as RF

X = [[0.0], [1.0]]
y = [[0.0, 1.0], [1.0, 0.0]]
model = RF().fit(X, y)
tl = treelite.sklearn.import_model(model)
AssertionError: Expected shape: (1, 1, 1), Got shape (1, 2, 1)
@RAMitchell RAMitchell mentioned this issue Mar 30, 2022
Merged
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this issue Apr 13, 2022
@RAMitchell
Treeshap hypothesis tests (#4671)
b3967cf 
Increased test coverage for TreeExplainer, greatly expanding model types tested. New tests take around 4.8s on my machine.

Fixes #4352

New bugs found:
#4663
dmlc/treelite#375
#4670

Authors:
  - Rory Mitchell (https://github.com/RAMitchell)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4671
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this issue Oct 9, 2023
@RAMitchell
Treeshap hypothesis tests (rapidsai#4671)
8c41231 
Increased test coverage for TreeExplainer, greatly expanding model types tested. New tests take around 4.8s on my machine.

Fixes rapidsai#4352

New bugs found:
rapidsai#4663
dmlc/treelite#375
rapidsai#4670

Authors:
  - Rory Mitchell (https://github.com/RAMitchell)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4671
@hcho3
Copy link
Collaborator

hcho3 commented Oct 25, 2023

Fixed in #524

@hcho3 hcho3 closed this as completed Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hcho3 @RAMitchell