Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Remove temporary regression workarounds #857

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Aug 1, 2019

Regression fixed by apache/mxnet#15707

@leezu leezu requested a review from szha as a code owner August 1, 2019 16:57
@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #857 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files          66       66           
  Lines        6345     6345           
=======================================
  Hits         5722     5722           
  Misses        623      623

@leezu leezu requested a review from sxjscience August 1, 2019 17:05
@mli
Copy link
Member

mli commented Aug 1, 2019

Found link check problems in job PR-857/1:
(line 19) broken https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/ - 404 Client Error: Not Found for url: https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/
(line 5) broken https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/ - 404 Client Error: Not Found for url: https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/
(line 5) broken https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/ - 404 Client Error: Not Found for url: https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/
(line 21) broken https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/ - 404 Client Error: Not Found for url: https://www.salesforce.com/products/einstein/ai-research/the-wikitext-dependency-language-modeling-dataset/
(line 442) broken https://www.aclweb.org/anthology/P02-1040.pdf)[1 - 404 Client Error: Not Found for url: https://www.aclweb.org/anthology/P02-1040.pdf)%5B1
(line 92) broken https://nlp.stanford.edu/pubs/glove.pdf)[2 - 404 Client Error: NOT FOUND for url: https://nlp.stanford.edu/pubs/glove.pdf)%5B2
(line 208) broken https://www.bioinf.jku.at/publications/older/2604.pdf)[3 - 404 Client Error: Not Found for url: https://www.bioinf.jku.at/publications/older/2604.pdf)%5B3

@mli
Copy link
Member

mli commented Aug 1, 2019

Job PR-857/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-857/1/index.html

@szha szha merged commit 366e53b into dmlc:master Aug 1, 2019
@leezu leezu deleted the removeregressionworkarounds branch August 2, 2019 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants