This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 534
Replace cython sampler with mxnet sampler to improve user experience #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-haibin-lin
changed the title
[WIP] replace cython sampler with mxnet sampler to improve user experience
Replace cython sampler with mxnet sampler to improve user experience
Aug 13, 2018
szha
approved these changes
Aug 13, 2018
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
- Coverage 75.12% 69.79% -5.33%
==========================================
Files 74 75 +1
Lines 6202 6277 +75
Branches 964 988 +24
==========================================
- Hits 4659 4381 -278
- Misses 1319 1697 +378
+ Partials 224 199 -25
Continue to review full report at Codecov.
|
Job PR-270/8 is complete. |
paperplanet
pushed a commit
to paperplanet/gluon-nlp
that referenced
this pull request
Jun 9, 2019
…mlc#270) * use mxnet op instead of ctype op * reduce verbosity in table * update instruction * fix lint * update mxnet dependency * add test * fix env var * fix CI weird err * update mxnet ver
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now we have _sample_unique_zipfian in mxnet, we don't need to build with cython.
Ran the training script end2end for 33 epochs, reached test ppl 44.15.
Checklist
Essentials
Changes
Comments