Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[CI] set doc options in makefile #1412

Merged
merged 1 commit into from
Oct 30, 2020
Merged

[CI] set doc options in makefile #1412

merged 1 commit into from
Oct 30, 2020

Conversation

szha
Copy link
Member

@szha szha commented Oct 29, 2020

Description

set doc options in makefile

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • set doc options in makefile
  • add --keep-going option for printing all warnings

@szha szha requested a review from a team as a code owner October 29, 2020 17:59
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #1412 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
- Coverage   85.24%   85.15%   -0.09%     
==========================================
  Files          53       53              
  Lines        6954     6954              
==========================================
- Hits         5928     5922       -6     
- Misses       1026     1032       +6     
Impacted Files Coverage Δ
src/gluonnlp/data/loading.py 81.13% <0.00%> (-2.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0484e64...b66c146. Read the comment docs.

@szha
Copy link
Member Author

szha commented Oct 29, 2020

@barry-jin the doc build should now print all warnings instead of aborting on the first warning

@sxjscience
Copy link
Member

Not sure why the doc is failing. Is it because the jupyter notebooks haven't been compiled?

@barry-jin
Copy link
Contributor

@szha Thanks for pointing it out. For now, I’m working on compile_notebooks.sh, which will not exit with failure if notebooks didn’t compile successfully. You can check build artifacts to find the failed compilation. Also the missing jupyternotebooks will be reported when building the website.

@szha
Copy link
Member Author

szha commented Oct 30, 2020

The warnings haven't been fixed. This change is just to expose them all at the same time instead of printing only one.

@barry-jin
Copy link
Contributor

I see. These warnings will be fixed in PR #1418 as they are caused by notebook compilation failures.

@sxjscience sxjscience merged commit 2032159 into dmlc:master Oct 30, 2020
@szha szha deleted the keep_going branch October 30, 2020 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants