Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix additional Apache MXNet branding issues #1747

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Fix additional Apache MXNet branding issues #1747

merged 2 commits into from
Jul 2, 2022

Conversation

josephevans
Copy link
Contributor

  • Remove MXNet logo from main page
  • change wording from 'powered by MXNet' to 'powered by Apache MXNet'.

@josephevans
Fix additional MXNet branding issues - remove MXNet logo from main pa…
42374f9 
…ge; change wording from 'powered by MXNet' to 'powered by Apache MXNet'.
@josephevans josephevans mentioned this pull request Jun 4, 2022
Closed
bryanyzhu
bryanyzhu approved these changes Jun 4, 2022
View reviewed changes
Copy link
Collaborator

@bryanyzhu bryanyzhu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It seems the change doesn't pass the CI doc test. Is there a permission issue?

@josephevans
Copy link
Contributor Author

Thanks for the PR. It seems the change doesn't pass the CI doc test. Is there a permission issue?

Hi, I'm not sure why the CI is not passing. It looks like it was trying to comment on this PR but failed. Can you re-run the CI pipeline again?

@bryanyzhu
Copy link
Collaborator

Hi @yinweisu @zhreshold , sorry to interrupt, any idea why the CI test fails on comment on PR? Does this affect our CI pipeline or the website? Thank you.

yinweisu
yinweisu requested changes Jun 28, 2022
View reviewed changes
.github/workflows/unittest.yml Outdated Show resolved Hide resolved
@yinweisu
Copy link
Collaborator

yinweisu commented Jun 28, 2022 •
edited
Loading

The workflow failed on building doc instead of commenting on PR. I think it failed because the build process took too long and the token granted to github action expired. Not sure why it took so long though

@yinweisu yinweisu mentioned this pull request Jun 28, 2022
Merged
@bryanyzhu
Copy link
Collaborator

Hi @josephevans We have fixed the CI pipeline (thanks to @yinweisu ). Can you rebase with master? I will merge your PR once the rebase is done. Thank you.

@josephevans
Copy link
Contributor Author

Hi @josephevans We have fixed the CI pipeline (thanks to @yinweisu ). Can you rebase with master? I will merge your PR once the rebase is done. Thank you.

Done, thanks for all your help!

@github-actions
Copy link

github-actions bot commented Jul 2, 2022

Job PR-1747-340e381 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1747/340e381/index.html

@bryanyzhu bryanyzhu merged commit e5af5f7 into dmlc:master Jul 2, 2022
@josephevans josephevans deleted the asf_branding branch July 5, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinweisu yinweisu yinweisu requested changes

@bryanyzhu bryanyzhu bryanyzhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephevans @bryanyzhu @yinweisu