Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torch auto classification task #1686

Merged
merged 8 commits into from
Jul 24, 2021
Merged

Torch auto classification task #1686

merged 8 commits into from
Jul 24, 2021

Conversation

yinweisu
Copy link
Collaborator

No description provided.

@yinweisu yinweisu requested a review from zhreshold July 23, 2021 00:46
@github-actions
Copy link

Job PR-1686-0d5e7e0 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1686/0d5e7e0/index.html

zhreshold
zhreshold reviewed Jul 23, 2021
View reviewed changes
gluoncv/auto/tasks/image_classification.py Outdated
# mxnet and torch dispatcher
dispatcher = None
torch_model_list = None
mxnet_model_list = list(get_model_list())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires mxnet here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think get_model_list() is part of gluoncv api and not require mxnet?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, model zoo still requires mxnet, only auto module can optionally use mxnet, otherwise gluoncv.torch is the right module

@github-actions
Copy link

Job PR-1686-c163afc is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1686/c163afc/index.html

zhreshold
zhreshold reviewed Jul 23, 2021
View reviewed changes
gluoncv/auto/tasks/image_classification.py Outdated
@@ -20,10 +20,11 @@
from autogluon.core.scheduler.resource import get_cpu_count, get_gpu_count
from autogluon.core.task.base import BaseTask
from autogluon.core.searcher import RandomSearcher
from gluoncv.model_zoo import get_model_list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here requires mxnet too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, in package import should use relative import, from ... import xx

@github-actions
Copy link

Job PR-1686-6e915f3 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1686/6e915f3/index.html

@github-actions
Copy link

Job PR-1686-5af5397 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1686/5af5397/index.html

@github-actions
Copy link

Job PR-1686-c140d5e is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1686/c140d5e/index.html

@github-actions
Copy link

Job PR-1686-cbed7ae is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1686/cbed7ae/index.html

@zhreshold
Copy link
Member

Thanks, I will merge it now

@zhreshold zhreshold merged commit c29aea8 into dmlc:master Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhreshold zhreshold zhreshold left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinweisu @zhreshold