-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt] Check data alignment before copying the file #7641
Conversation
To trigger regression tests:
|
Does this fix running our examples with products? |
It fixes loading the feature file for DiskBasedFeature. But I find there is another issue. The training will stuck at the first iteration of the first epoch when running on products and arxiv. I don't think it has to do with this PR as I reproduce the results on ogbn-arxiv without applying changes in this PR. But I will still post it here FYI. I run this:
When I interrupt the process by crtl+c, the full output is:
|
This issue is known and it is the same issue as batch dependency 4096 taking longer than batch dependency=1 and 64. It will be fixed today. |
@Liu-rj When the cache capacity is not at least a few multiples larger than the requests being made to the cache (the number of sampled nodes in a minibatch), this is expected behavior. I will update the documentation to indicate that the cache size should be larger than the largest request being made. It is a bit hard to fix the infinite loop issue, if the user is using the cache like this, then the user is doing it wrong. |
Description
The
node-feat.npy
of products dataset is not saved in C_CONTIGUOUS (and possibly the same for other small datasets). Currently there is no check on the flags before directly copying the file, which will leads to errors here if the data file is not C_CONTIGUOUS.A simple solution here is to judge whether the data file is C_CONTIGUOUS. If yes, we can directly copy the file, otherwise we will need to proceed the save process.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes