Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Refactor FeatureFetcher to use read_async. #7559

Merged
merged 11 commits into from
Jul 22, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 21, 2024

Description

Depended on #7558. Tested with our examples. The CI should pass now.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs July 21, 2024 23:33
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 21, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 21, 2024

Commit ID: 844044f

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 21, 2024

Commit ID: 93248e3

Build ID: 2

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: 4a644f1

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: 073f0c3

Build ID: 4

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: 473be9c

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: 789ff2d

Build ID: 6

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: 3a63bca

Build ID: 7

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: 51f5ce5

Build ID: 8

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: 239f313

Build ID: 9

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: d5868dc2dfb1ffea8ca1dda185f273ab1d0ddca0

Build ID: 10

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

python/dgl/graphbolt/feature_fetcher.py Outdated Show resolved Hide resolved
python/dgl/graphbolt/feature_fetcher.py Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: 3964a6f8d60d28c032896563016ed804849cacba

Build ID: 11

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit 2074cbf into dmlc:master Jul 22, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_feature_fetcher_refactor_read_async branch July 22, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GraphBolt] CPU RAM Feature Cache for DiskBasedFeature [GraphBolt] Refactor feature store
3 participants