-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt] Add read_async
to gb.Feature
. [1]
#7546
Conversation
read_async
to gb.Feature
.read_async
to gb.Feature
. [1]
To trigger regression tests:
|
https://dgl-ci-result.s3.us-west-2.amazonaws.com/dgl/PR-7546/2/2/logs/report.html
|
""" | ||
raise NotImplementedError | ||
|
||
def read_async_num_stages(self, ids_device: torch.device): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you already returned an async_handle, why do you need to define read_async_num_stages?
Consider merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because read_async
returns a generator object. There is no way to also return how many stages are in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can always override the generator object to provide an extra field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. implement the len function of the object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I do that?
Description
#7540 first part.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes