Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sparse] Support converson to/from torch sparse tensor. #5388

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

czkkkkkk
Copy link
Collaborator

@czkkkkkk czkkkkkk commented Feb 27, 2023

Description

Resolve #5373, #5145.

  • Support conversions to/from torch sparse tensor.
  • Use the stacked row and column tensor in C++ FromCOO.
  • Fix typos in the from_coo, from_csr, from_csc docstrings.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 27, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 27, 2023

Commit ID: fd72a95

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 27, 2023

Commit ID: 4f0b446

Build ID: 2

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

Copy link
Collaborator

@frozenbugs frozenbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: consider move non-class method to dgl/sparse/sparse_matrix_utils.py

python/dgl/sparse/sparse_matrix.py Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 27, 2023

Commit ID: f45209a

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 27, 2023

Commit ID: 6ded6cc3a45e4ff40fbbc08b4dd60efb6125b3ad

Build ID: 4

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 27, 2023

Commit ID: 18db0d56ceb8686445eb7f024e1ec7f29a840d0d

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@czkkkkkk czkkkkkk merged commit 999c624 into dmlc:master Feb 28, 2023
@czkkkkkk czkkkkkk deleted the torch_sparse branch February 28, 2023 09:27
czkkkkkk added a commit that referenced this pull request Apr 19, 2023
* [Sparse] Support converson to/from torch sparse tensor.

* Update
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
* [Sparse] Support converson to/from torch sparse tensor.

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sparse] Convert Torch sparse tensor to SparseMatrix without overhead.
3 participants