Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/refactor-inflight-messages #1

Merged
merged 5 commits into from
Oct 29, 2023

Conversation

dginzbourg
Copy link
Collaborator

Resolves #NUMBER

Description:
Implement asynchronous message processing and polling up to maxInflightMessages.
graceful shutdown termination was added to await inflight messages be consumed.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [* ] Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:
The original library doesn't support asynchronous messages processing and polling to buffer the messages

Code changes:

  • Consumer calls polling and creates asycn handlers to process messages
  • Polling is done until maxInflightMessages reached, then it perorms timeout waiting until inflight messages number is reduced

Checklist:

  • [+] My code follows the code style of this project.
  • [+] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dmitrydigi dmitrydigi merged commit 23fa268 into main Oct 29, 2023
4 of 5 checks passed
@dmitrydigi dmitrydigi deleted the feature/refactor-inflight-messages branch October 29, 2023 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants