-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Consistently integrate addWhereClause #539
base: development
Are you sure you want to change the base?
[BUGFIX] Consistently integrate addWhereClause #539
Conversation
Other occurences, already prefixed with a space: typo3-realurl/Classes/Decoder/UrlDecoder.php Lines 318 to 321 in 58a17ac
typo3-realurl/Classes/Encoder/UrlEncoder.php Lines 420 to 422 in 58a17ac
On the other hand, the wiki already states:
(https://github.com/dmitryd/typo3-realurl/wiki/Configuration-reference#lookuptable) The current code poses a little trap, because it is not immediately obvious that you have a wrong configuration, since it works in some cases. |
I'm happy to change the pull request into removing the additional space on every occurence if you like that better. I just recommend to avoid the inconsistency. |
Read the docs:
|
Basically the space should be in |
The addWhereClause was twice prefixed by a space and twice not. This change makes all occurences consistently not include a prefix.
3943e44
to
e35ce9c
Compare
Changed the pull request to consistently not include a space. |
I like the change but I am afraid that there will be people who do not use space and will complain that their setup suddenly stopped working. |
The addWhereClause is twice prefixed by a space and twice not. This
change makes all occurences consistently include a prefix space, thus
avoiding possibly invalid sql.